Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AmplitudeClient.makeEventUploadPostRequest shall check HTTP response 200 rather than matching string response to "success" #348

Closed
jackcsk opened this issue Jan 27, 2023 · 0 comments · Fixed by #349
Labels
question Further information is requested

Comments

@jackcsk
Copy link

jackcsk commented Jan 27, 2023

Summary

In related to the amplitude-javascript pull request amplitude/Amplitude-JavaScript#572, AmplitudeClient.makeEventUploadPostRequest(client, event, maxEventId, maxIdentifyId) shall match Response.code to 200 rather than doing a string comparison of "success"

Current behavior blocks the usage of custom amplitude proxy, which returns HTTP 200 response in this format:

{"code":200,"status":"SUCCESS","data":true}

Error Message

From logcat:

01-27 19:17:55.455 17721 17910 W com.amplitude.api.AmplitudeClient: Upload failed, {"code":200,"status":"SUCCESS","data":true}
01-27 19:17:55.455 17721 17910 W com.amplitude.api.AmplitudeClient: , will attempt to reupload later
@jackcsk jackcsk added the question Further information is requested label Jan 27, 2023
@yuhao900914 yuhao900914 linked a pull request Jan 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant