Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Install Script Fails in 7.2.0 version due to yarn dependency missing #298

Closed
anu1097 opened this issue Sep 22, 2020 · 7 comments · Fixed by #301
Closed

Post Install Script Fails in 7.2.0 version due to yarn dependency missing #298

anu1097 opened this issue Sep 22, 2020 · 7 comments · Fixed by #301
Assignees
Labels
bug Something isn't working

Comments

@anu1097
Copy link

anu1097 commented Sep 22, 2020

Post install script fails for 7.2.0 version. It uses yarn. Our source doesn't use yarn to manage its dependencies. 7.1.1. didn't have this script.

Console Output -

[email protected] postinstall /home/ubuntu/xxxxxxxxxx/node_modules/amplitude-js
cd website/ && yarn install
sh: 1: yarn: not found
[?25l[[7m [27m[90m......[0m] \ postinstall: [32minfo[0m [35mlifecycle[0m [email protected]~postinsta[0m[K]
[37;40mnpm[0m [0m[31;40mERR![0m [0m[35mcode[0m ELIFECYCLE
[0m[37;40mnpm[0m [0m[31;40mERR![0m [0m[35msyscall[0m spawn
[0m[37;40mnpm[0m [0m[31;40mERR![0m [0m[35mfile[0m sh
[0m[37;40mnpm[0m [0m[31;40mERR![0m [0m[35merrno[0m ENOENT
[0m[37;40mnpm[0m [0m[31;40mERR![0m[35m[0m [email protected] postinstall: cd website/ && yarn install
[0m[37;40mnpm[0m [0m[31;40mERR![0m[35m[0m spawn ENOENT
[0m[37;40mnpm[0m [0m[31;40mERR![0m[35m[0m
[0m[37;40mnpm[0m [0m[31;40mERR![0m[35m[0m Failed at the [email protected] postinstall script.
[0m[37;40mnpm[0m [0m[31;40mERR![0m[35m[0m This is probably not a problem with npm. There is likely additional logging output above.

Expected Behavior

Backward compatibility. If yarn is not available use npm.

Current Behavior

Expects Clients to have yarn as a dependency to run its post install script.

Possible Solution

Not use yarn or use npm if yarn not available. Or add yarn as a dependency.

Steps to Reproduce

  1. Run post install script. Don't have yarn as a package manager

Environment

Node

@anu1097 anu1097 added the bug Something isn't working label Sep 22, 2020
@anu1097 anu1097 changed the title Post Install Scrip Fails in 7.2.0 version due to yarn dependency missing Post Install Script Fails in 7.2.0 version due to yarn dependency missing Sep 22, 2020
@FadiAboMsalam
Copy link

+1

1 similar comment
@alyaptsev
Copy link

+1

@alyaptsev
Copy link

alyaptsev commented Sep 22, 2020

Is it really needed to install documentation dependencies if amplitude-js is transitive dependency?

@pier-verdu
Copy link

Same, any update?

@jooohhn
Copy link
Contributor

jooohhn commented Sep 22, 2020

Looking at it right now

@jooohhn jooohhn self-assigned this Sep 22, 2020
@github-actions
Copy link

🎉 This issue has been resolved in version 7.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jooohhn
Copy link
Contributor

jooohhn commented Sep 22, 2020

Thanks for the notice guys. Should be fixed in 7.2.1 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants