From 4ac5a6e1e3261106a1365784d37c086c87b08d0b Mon Sep 17 00:00:00 2001 From: Taylor Evanko Date: Tue, 10 Aug 2021 10:07:15 -0700 Subject: [PATCH 1/2] LGTM - return fix for falsy str --- src/metadata-storage.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/metadata-storage.js b/src/metadata-storage.js index 5888738d..04c3052f 100644 --- a/src/metadata-storage.js +++ b/src/metadata-storage.js @@ -193,7 +193,9 @@ class MetadataStorage { utils.log.info(`window.sessionStorage unavailable. Reason: "${e}"`); } } - if (!str) false; + if (!str) { + return false; + } return true; } } From 01e0081b46700cc3529462d21a294b4125402ca9 Mon Sep 17 00:00:00 2001 From: Taylor Evanko Date: Tue, 10 Aug 2021 14:40:21 -0700 Subject: [PATCH 2/2] condensing str return logic --- src/metadata-storage.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/metadata-storage.js b/src/metadata-storage.js index 04c3052f..67a0ba5b 100644 --- a/src/metadata-storage.js +++ b/src/metadata-storage.js @@ -193,10 +193,7 @@ class MetadataStorage { utils.log.info(`window.sessionStorage unavailable. Reason: "${e}"`); } } - if (!str) { - return false; - } - return true; + return !!str } }