fix: Prevent periods in device id check #405
Merged
+57
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajhorst
reviewed
Jun 9, 2021
ajhorst
reviewed
Jun 9, 2021
ajhorst
reviewed
Jun 9, 2021
ajhorst
approved these changes
Jun 10, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Jun 10, 2021
## [8.3.1](v8.3.0...v8.3.1) (2021-06-10) ### Bug Fixes * Prevent periods in device id check ([#405](#405)) ([b872d7e](b872d7e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Periods in device ID checks broke the SDK storage behavior. This is because metadata is stored in cookies and delimited by periods. This PR fixes the behavior by rejecting device IDs with periods
Checklist