Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: eu dynamic configuration support #439

Merged
merged 3 commits into from
Oct 28, 2021
Merged

feat: eu dynamic configuration support #439

merged 3 commits into from
Oct 28, 2021

Conversation

qingzhuozhen
Copy link
Contributor

@qingzhuozhen qingzhuozhen commented Oct 23, 2021 •
edited
Loading

Summary

  • Add EU server zone in options
  • Add Dynamic Configuration, with option useDynamicConfig
  • Unit tests

Pending discussion and issues:

  • Dynamic Configuration endpoint CORS is now fixed, tested on local
  • Refresh now is in init method, do we need to refresh in different time? Or we just suggest user to call it explicitly if needed?

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

ajhorst
ajhorst reviewed Oct 25, 2021
View reviewed changes
ajhorst
ajhorst reviewed Oct 25, 2021
View reviewed changes
@ajhorst
Copy link
Contributor

ajhorst commented Oct 25, 2021

Some small questions, overall looks good

@qingzhuozhen qingzhuozhen requested a review from ajhorst October 26, 2021 07:03
ajhorst
ajhorst approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@ajhorst ajhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@qingzhuozhen qingzhuozhen marked this pull request as ready for review October 28, 2021 02:09
qingzhuozhen
qingzhuozhen commented Oct 28, 2021
View reviewed changes
src/options.js
@@ -107,4 +111,7 @@ export default {
'Content-Type': 'application/x-www-form-urlencoded; charset=UTF-8',
'Cross-Origin-Resource-Policy': 'cross-origin',
},
serverZone: AmplitudeServerZone.US,
useDynamicConfig: false,
serverZoneBasedApi: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to false, to not breaking current customers with custom proxy server.

@qingzhuozhen qingzhuozhen merged commit 0618a90 into main Oct 28, 2021
@qingzhuozhen qingzhuozhen deleted the eu-dynamic-configuration-support branch October 28, 2021 05:07
github-actions bot pushed a commit that referenced this pull request Oct 28, 2021
@amplitude-sdk-bot
chore(release): 8.9.0 [skip ci]
57a47ca 
# [8.9.0](v8.8.0...v8.9.0) (2021-10-28)

### Features

* eu dynamic configuration support ([#439](#439)) ([0618a90](0618a90))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajhorst ajhorst ajhorst approved these changes

@yuhao900914 yuhao900914 Awaiting requested review from yuhao900914

@jooohhn jooohhn Awaiting requested review from jooohhn

@haoliu-amp haoliu-amp Awaiting requested review from haoliu-amp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qingzhuozhen @ajhorst