Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add public method onNewSessionStart to snippet #459

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

kevinpagtakhan
Copy link
Contributor

Summary

PR #455 adds a new public method. This public method needs to be added to the snippet to allow the method to be called while amplitude.js script is being loaded.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change? None

@ajhorst
Copy link
Contributor

ajhorst commented Nov 30, 2021

@kevinpagtakhan There's a separate copy of the snippet on the JS help docs page, so make sure this new method is added there as well

@kevinpagtakhan
Copy link
Contributor Author

@jooohhn i remember you mentioned that you put out a strategy to pull the latest version of the snippet from npm to be used in docs so we don't have to manually update it each time. is that already in effect?

cc @ajhorst

@kevinpagtakhan kevinpagtakhan merged commit 07446fc into main Nov 30, 2021
@kevinpagtakhan kevinpagtakhan deleted the AMP-45559-snippet-update branch November 30, 2021 20:56
github-actions bot pushed a commit that referenced this pull request Nov 30, 2021
# [8.13.0](v8.12.0...v8.13.0) (2021-11-30)

### Bug Fixes

* add public method onNewSessionStart to snippet ([#459](#459)) ([07446fc](07446fc))
* upgrade to @amplitude/[email protected] ([#456](#456)) ([8962604](8962604))

### Features

* add support for on new session start callback ([#455](#455)) ([acf596a](acf596a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants