feat: enable the ability to overwrite the referrer #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging e98b248 into 385c8f4 - view on LGTM.com new alerts:
|
kevinpagtakhan
approved these changes
Aug 24, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
# [8.20.0](v8.19.0...v8.20.0) (2022-08-24) ### Features * enable the ability to overwrite the referrer ([#551](#551)) ([03c0a89](03c0a89))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://discourse.amplitude.com/t/incorrectly-logged-referrer-due-to-cookie-control/7164
This pr for providing the ability to let customers overwrite the referrer info.
The use case:
Customer need to defer the initialization with the cookie control. Before accepting cookies, the users might redirect to other pages. And the
document.referrerwill be set to the last page they were on. So they will lose the original referrer info after enabling tracking.This pr enable customer using this SDK to pass an overwrite value through url parameter in order to overwrite the referrer info.
Checklist