Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PackageTypes from the match.Matcher interface #2493

Closed
kzantow opened this issue Feb 28, 2025 · 1 comment
Closed

Remove PackageTypes from the match.Matcher interface #2493

kzantow opened this issue Feb 28, 2025 · 1 comment
Labels
duplicate This issue or pull request already exists
Milestone

Comments

@kzantow
Copy link
Contributor

kzantow commented Feb 28, 2025

During the recent v6 refactoring, investigation of the matching processes led me to believe that matchers should not be directly tied to specific package types. An example of something that causes issues is golang, where go modules should be matched one way, but go stdlib should fall though to standard matching. The stock matcher, for example, could be configured to skip CPE matching for certain types, rather than requiring effectively duplicating the stock matcher to specific package type matchers only to configure them separately.

@kzantow kzantow added this to the Grype 1.0 milestone Feb 28, 2025
@kzantow
Copy link
Contributor Author

kzantow commented Mar 27, 2025

This is a duplicate of #2112

@kzantow kzantow closed this as completed Mar 27, 2025
@github-project-automation github-project-automation bot moved this to Done in OSS Mar 27, 2025
@kzantow kzantow added the duplicate This issue or pull request already exists label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
Status: Done
Development

No branches or pull requests

1 participant