feedback: more gradle bom usage cleanup

jdaugherty · jdaugherty · commit 35cb12a4feb4 · 2025-03-10T09:21:46.000-04:00
diff --git a/build.gradle b/build.gradle
@@ -1,16 +1,3 @@
-buildscript {
-    repositories {
-        maven { url = 'https://repo.grails.org/grails/core' }
-    }
-    dependencies {
-        classpath platform("org.grails:grails-bom:${grailsVersion}"), {
-            exclude group: 'org.grails.plugins', module: 'views-gradle'
-            exclude group: 'org.grails.plugins', module: 'views-json'
-        }
-        classpath 'org.grails:grails-gradle-plugin'
-    }
-}
-
 ext {
     isCI = System.getenv('CI') != null
 }
diff --git a/fields/plugin/build.gradle b/fields/plugin/build.gradle
@@ -18,7 +18,7 @@ ext {
 
 dependencies {
     implementation platform("org.grails:grails-bom:${grailsVersion}"), {
-        exclude group: 'org.grails.plugins', module: 'gsp'
+        exclude group: 'org.grails.plugins', module: 'gsp' // as a safeguard, exclude projects in this repo to ensure we pick the right version
     }
 
     implementation project(':grails-plugin-gsp')
diff --git a/scaffolding/build.gradle b/scaffolding/build.gradle
@@ -16,8 +16,7 @@ ext {
 
 dependencies {
     implementation platform("org.grails:grails-bom:$grailsVersion"), {
-        exclude group: 'org.grails.plugins', module: 'views-gradle'
-        exclude group: 'org.grails.plugins', module: 'views-json'
+        // as a safeguard, exclude projects in this repo that included transitively to ensure we pick the right version
         exclude group: 'org.grails', module: 'views-core'
         exclude group: 'org.grails', module: 'views-json-testing-support'
         exclude group: 'org.grails.plugins', module: 'scaffolding'
diff --git a/views/core/build.gradle b/views/core/build.gradle
@@ -13,8 +13,7 @@ ext {
 
 dependencies {
     implementation platform("org.grails:grails-bom:$grailsVersion"), {
-        exclude group: 'org.grails.plugins', module: 'views-gradle'
-        exclude group: 'org.grails.plugins', module: 'views-json'
+        // as a safeguard, exclude projects in this repo that included transitively to ensure we pick the right version
         exclude group: 'org.grails', module: 'views-core'
         exclude group: 'org.grails', module: 'views-json-testing-support'
         exclude group: 'org.grails.plugins', module: 'scaffolding'
diff --git a/views/examples/functional-tests-plugin/build.gradle b/views/examples/functional-tests-plugin/build.gradle
@@ -10,8 +10,7 @@ group = 'functional.tests.plugin'
 
 dependencies {
     implementation platform("org.grails:grails-bom:${grailsVersion}"), {
-        exclude group: 'org.grails.plugins', module: 'views-gradle'
-        exclude group: 'org.grails.plugins', module: 'views-json'
+        // as a safeguard, exclude projects in this repo that included transitively to ensure we pick the right version
         exclude group: 'org.grails', module: 'views-core'
     }
 
diff --git a/views/examples/functional-tests/build.gradle b/views/examples/functional-tests/build.gradle
@@ -10,8 +10,7 @@ group = 'functional.tests'
 
 dependencies {
     implementation platform("org.grails:grails-bom:$grailsVersion"), {
-        exclude group: 'org.grails.plugins', module: 'views-gradle'
-        exclude group: 'org.grails.plugins', module: 'views-json'
+        // as a safeguard, exclude projects in this repo that included transitively to ensure we pick the right version
         exclude group: 'org.grails', module: 'views-core'
         exclude group: 'org.grails', module: 'views-json-testing-support'
         exclude group: 'org.grails.plugins', module: 'scaffolding'
diff --git a/views/gradle-plugin/build.gradle b/views/gradle-plugin/build.gradle
@@ -46,8 +46,7 @@ repositories {
 
 dependencies {
     implementation platform("org.grails:grails-bom:$grailsVersion"), {
-        exclude group: 'org.grails.plugins', module: 'views-gradle'
-        exclude group: 'org.grails.plugins', module: 'views-json'
+        // as a safeguard, exclude projects in this repo that included transitively to ensure we pick the right version
         exclude group: 'org.grails', module: 'views-core'
         exclude group: 'org.grails', module: 'views-json-testing-support'
         exclude group: 'org.grails.plugins', module: 'scaffolding'
diff --git a/views/json-testing-support/build.gradle b/views/json-testing-support/build.gradle
@@ -13,8 +13,7 @@ ext {
 
 dependencies {
     implementation platform("org.grails:grails-bom:$grailsVersion"), {
-        exclude group: 'org.grails.plugins', module: 'views-gradle'
-        exclude group: 'org.grails.plugins', module: 'views-json'
+        // as a safeguard, exclude projects in this repo that included transitively to ensure we pick the right version
         exclude group: 'org.grails', module: 'views-core'
         exclude group: 'org.grails', module: 'views-json-testing-support'
         exclude group: 'org.grails.plugins', module: 'scaffolding'
diff --git a/views/json/build.gradle b/views/json/build.gradle
@@ -14,8 +14,7 @@ ext {
 
 dependencies {
     implementation platform("org.grails:grails-bom:$grailsVersion"), {
-        exclude group: 'org.grails.plugins', module: 'views-gradle'
-        exclude group: 'org.grails.plugins', module: 'views-json'
+        // as a safeguard, exclude projects in this repo that included transitively to ensure we pick the right version
         exclude group: 'org.grails', module: 'views-core'
         exclude group: 'org.grails', module: 'views-json-testing-support'
         exclude group: 'org.grails.plugins', module: 'scaffolding'
diff --git a/views/markup/build.gradle b/views/markup/build.gradle
@@ -14,8 +14,7 @@ ext {
 
 dependencies {
     implementation platform("org.grails:grails-bom:$grailsVersion"), {
-        exclude group: 'org.grails.plugins', module: 'views-gradle'
-        exclude group: 'org.grails.plugins', module: 'views-json'
+        // as a safeguard, exclude projects in this repo that included transitively to ensure we pick the right version
         exclude group: 'org.grails', module: 'views-core'
         exclude group: 'org.grails', module: 'views-json-testing-support'
         exclude group: 'org.grails.plugins', module: 'scaffolding'

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ ext {`
`18`	`18`
`19`	`19`	`dependencies {`
`20`	`20`	`implementation platform("org.grails:grails-bom:${grailsVersion}"), {`
`21`		`- exclude group: 'org.grails.plugins', module: 'gsp'`
	`21`	`+ exclude group: 'org.grails.plugins', module: 'gsp' // as a safeguard, exclude projects in this repo to ensure we pick the right version`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`implementation project(':grails-plugin-gsp')`
Original file line number	Diff line number	Diff line change
`@@ -10,8 +10,7 @@ group = 'functional.tests.plugin'`
`10`	`10`
`11`	`11`	`dependencies {`
`12`	`12`	`implementation platform("org.grails:grails-bom:${grailsVersion}"), {`
`13`		`- exclude group: 'org.grails.plugins', module: 'views-gradle'`
`14`		`- exclude group: 'org.grails.plugins', module: 'views-json'`
	`13`	`+ // as a safeguard, exclude projects in this repo that included transitively to ensure we pick the right version`
`15`	`14`	`exclude group: 'org.grails', module: 'views-core'`
`16`	`15`	`}`
`17`	`16`