Use 'count' as the default metric when available #4606
Merged
+55
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Count is a much better default than the current behavior which is to use whatever the first metric in the list happens to be.
mistercrunch
force-pushed
the
main_metric
branch
from
8cefaf6 to
1c72ed9
Compare
Codecov Report
@@ Coverage Diff @@
## master #4606 +/- ##
==========================================
+ Coverage 71.18% 71.24% +0.05%
==========================================
Files 189 190 +1
Lines 14847 14895 +48
Branches 1086 1101 +15
==========================================
+ Hits 10569 10612 +43
- Misses 4275 4280 +5
Partials 3 3
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Mar 19, 2018
| expect(mainMetric([])).to.equal(undefined); | ||
| expect(mainMetric(null)).to.equal(undefined); | ||
| }); | ||
| it('is prefers the "count" metric when first', () => { |
There was a problem hiding this comment.
Nit: remove "is" before "prefers".
| ]; | ||
| expect(mainMetric(metrics)).to.equal('count'); | ||
| }); | ||
| it('is prefers the "count" metric when not first', () => { |
There was a problem hiding this comment.
Nit: remove "is" before "prefers".
| ]; | ||
| expect(mainMetric(metrics)).to.equal('count'); | ||
| }); | ||
| it('it selects the first metric when "count" is not an option', () => { |
There was a problem hiding this comment.
Nit: remove "it" before "selects".
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 30, 2018
* Use 'count' as the default metric when available Count is a much better default than the current behavior which is to use whatever the first metric in the list happens to be. * Addressing nits
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 30, 2018
* Use 'count' as the default metric when available Count is a much better default than the current behavior which is to use whatever the first metric in the list happens to be. * Addressing nits
hughhhh
pushed a commit
to lyft/incubator-superset
that referenced
this pull request
Mar 30, 2018
* Use 'count' as the default metric when available Count is a much better default than the current behavior which is to use whatever the first metric in the list happens to be. * Addressing nits
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
* Use 'count' as the default metric when available Count is a much better default than the current behavior which is to use whatever the first metric in the list happens to be. * Addressing nits
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
* Use 'count' as the default metric when available Count is a much better default than the current behavior which is to use whatever the first metric in the list happens to be. * Addressing nits
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Count is a much better default than the current behavior which is to use whatever the first metric in the list happens to be.