Refactor MetaDataPersistFacade (#35000)

Author: terrymanu

mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/manager/rule/DatabaseRuleItemManager.java

@@ -56,7 +56,7 @@ public final class DatabaseRuleItemManager {
     public void alter(final DatabaseRuleNodePath databaseRuleNodePath) throws SQLException {
         RuleItemConfigurationChangedProcessor processor = TypedSPILoader.getService(RuleItemConfigurationChangedProcessor.class,
                 new RuleChangedItemType(databaseRuleNodePath.getRuleType(), databaseRuleNodePath.getDatabaseRuleItem().getType()));
-        String yamlContent = metaDataPersistFacade.getMetaDataVersionService().loadContent(new VersionNodePath(databaseRuleNodePath));
+        String yamlContent = metaDataPersistFacade.getVersionService().loadContent(new VersionNodePath(databaseRuleNodePath));
         String databaseName = databaseRuleNodePath.getDatabase().getDatabaseName();
         RuleConfiguration currentRuleConfig = processor.findRuleConfiguration(metaDataContexts.getMetaData().getDatabase(databaseName));
         String itemName = databaseRuleNodePath.getDatabaseRuleItem().getName();

mode/core/src/main/java/org/apache/shardingsphere/mode/metadata/persist/MetaDataPersistFacade.java

@@ -56,7 +56,7 @@ public final class MetaDataPersistFacade {
 
     private final PersistRepository repository;
 
-    private final VersionPersistService metaDataVersionService;
+    private final VersionPersistService versionService;
 
     private final DataSourceUnitPersistService dataSourceUnitService;
 
@@ -72,12 +72,12 @@ public final class MetaDataPersistFacade {
 
     public MetaDataPersistFacade(final PersistRepository repository) {
         this.repository = repository;
-        metaDataVersionService = new VersionPersistService(repository);
+        versionService = new VersionPersistService(repository);
         dataSourceUnitService = new DataSourceUnitPersistService(repository);
-        databaseMetaDataFacade = new DatabaseMetaDataPersistFacade(repository, metaDataVersionService);
+        databaseMetaDataFacade = new DatabaseMetaDataPersistFacade(repository, versionService);
         databaseRuleService = new DatabaseRulePersistService(repository);
-        globalRuleService = new GlobalRulePersistService(repository, metaDataVersionService);
-        propsService = new PropertiesPersistService(repository, metaDataVersionService);
+        globalRuleService = new GlobalRulePersistService(repository, versionService);
+        propsService = new PropertiesPersistService(repository, versionService);
         statisticsService = new StatisticsPersistService(repository);
     }
 

mode/type/standalone/core/src/test/java/org/apache/shardingsphere/mode/manager/standalone/persist/service/StandaloneMetaDataManagerPersistServiceTest.java

@@ -166,7 +166,7 @@ void assertAlterSingleRuleConfiguration() throws SQLException {
     @Test
     void assertAlterNullRuleConfiguration() throws SQLException {
         metaDataManagerPersistService.alterRuleConfiguration(new ShardingSphereDatabase("foo_db", mock(), mock(), mock(), Collections.emptyList()), null);
-        verify(metaDataPersistFacade, times(0)).getMetaDataVersionService();
+        verify(metaDataPersistFacade, times(0)).getVersionService();
     }
 
     @Test
@@ -195,7 +195,7 @@ void assertAlterRuleConfiguration() throws SQLException {
     @Test
     void assertRemoveNullRuleConfigurationItem() throws SQLException {
         metaDataManagerPersistService.removeRuleConfigurationItem(new ShardingSphereDatabase("foo_db", mock(), mock(), mock(), Collections.emptyList()), null);
-        verify(metaDataPersistFacade, times(0)).getMetaDataVersionService();
+        verify(metaDataPersistFacade, times(0)).getVersionService();
     }
 
     @Test