Skip to content

Commit 7871170

Browse files
authored
Remove NodePathSearchCriteria.trimEmptyNode (#34969)
1 parent e8c6f26 commit 7871170

24 files changed

+31
-33
lines changed

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/engine/searcher/NodePathSearchCriteria.java

-2
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ public final class NodePathSearchCriteria {
3030

3131
private final NodePath searchExample;
3232

33-
private final boolean trimEmptyNode;
34-
3533
private final boolean containsChildPath;
3634

3735
private final int searchSegmentIndex;

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/engine/searcher/NodePathSearcher.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public final class NodePathSearcher {
4242
* @return found node segment
4343
*/
4444
public static Optional<String> find(final String path, final NodePathSearchCriteria criteria) {
45-
Matcher matcher = createPattern(criteria.getSearchExample(), criteria.isTrimEmptyNode(), criteria.isContainsChildPath()).matcher(path);
45+
Matcher matcher = createPattern(criteria.getSearchExample(), criteria.isContainsChildPath()).matcher(path);
4646
return matcher.find() ? Optional.of(matcher.group(criteria.getSearchSegmentIndex())) : Optional.empty();
4747
}
4848

@@ -65,11 +65,11 @@ public static String get(final String path, final NodePathSearchCriteria criteri
6565
* @return is matched path or not
6666
*/
6767
public static boolean isMatchedPath(final String path, final NodePathSearchCriteria criteria) {
68-
return createPattern(criteria.getSearchExample(), criteria.isTrimEmptyNode(), criteria.isContainsChildPath()).matcher(path).find();
68+
return createPattern(criteria.getSearchExample(), criteria.isContainsChildPath()).matcher(path).find();
6969
}
7070

71-
private static Pattern createPattern(final NodePath searchExample, final boolean trimEmptyNode, final boolean containsChildPath) {
71+
private static Pattern createPattern(final NodePath searchExample, final boolean containsChildPath) {
7272
String endPattern = containsChildPath ? "?" : "$";
73-
return Pattern.compile(START_PATTERN + NodePathGenerator.toPath(searchExample, trimEmptyNode) + endPattern, Pattern.CASE_INSENSITIVE);
73+
return Pattern.compile(START_PATTERN + NodePathGenerator.toPath(searchExample, false) + endPattern, Pattern.CASE_INSENSITIVE);
7474
}
7575
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/database/metadata/DatabaseMetaDataNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,6 @@ public final class DatabaseMetaDataNodePath implements NodePath {
4040
* @return created search criteria
4141
*/
4242
public static NodePathSearchCriteria createDatabaseSearchCriteria() {
43-
return new NodePathSearchCriteria(new DatabaseMetaDataNodePath(NodePathPattern.IDENTIFIER), false, true, 1);
43+
return new NodePathSearchCriteria(new DatabaseMetaDataNodePath(NodePathPattern.IDENTIFIER), true, 1);
4444
}
4545
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/database/metadata/datasource/StorageNodeNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@ public StorageNodeNodePath(final String databaseName, final String storageNodeNa
4747
* @return created search criteria
4848
*/
4949
public static NodePathSearchCriteria createStorageNodeSearchCriteria(final String databaseName) {
50-
return new NodePathSearchCriteria(new StorageNodeNodePath(databaseName, NodePathPattern.IDENTIFIER), false, true, 1);
50+
return new NodePathSearchCriteria(new StorageNodeNodePath(databaseName, NodePathPattern.IDENTIFIER), true, 1);
5151
}
5252
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/database/metadata/datasource/StorageUnitNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@ public StorageUnitNodePath(final String databaseName, final String storageUnitNa
4747
* @return created search criteria
4848
*/
4949
public static NodePathSearchCriteria createStorageUnitSearchCriteria(final String databaseName) {
50-
return new NodePathSearchCriteria(new StorageUnitNodePath(databaseName, NodePathPattern.IDENTIFIER), false, true, 1);
50+
return new NodePathSearchCriteria(new StorageUnitNodePath(databaseName, NodePathPattern.IDENTIFIER), true, 1);
5151
}
5252
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/database/metadata/rule/DatabaseRuleNodePath.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public DatabaseRuleNodePath(final String databaseName, final String ruleType, fi
5050
* @return create search criteria
5151
*/
5252
public static NodePathSearchCriteria createRuleTypeSearchCriteria(final String databaseName) {
53-
return new NodePathSearchCriteria(new DatabaseRuleNodePath(databaseName, NodePathPattern.IDENTIFIER, null), false, true, 1);
53+
return new NodePathSearchCriteria(new DatabaseRuleNodePath(databaseName, NodePathPattern.IDENTIFIER, null), true, 1);
5454
}
5555

5656
/**
@@ -62,6 +62,6 @@ public static NodePathSearchCriteria createRuleTypeSearchCriteria(final String d
6262
* @return create search criteria
6363
*/
6464
public static NodePathSearchCriteria createRuleItemNameSearchCriteria(final String databaseName, final String ruleType, final String ruleItemType) {
65-
return new NodePathSearchCriteria(new DatabaseRuleNodePath(databaseName, ruleType, new DatabaseRuleItem(ruleItemType, NodePathPattern.QUALIFIED_IDENTIFIER)), false, true, 1);
65+
return new NodePathSearchCriteria(new DatabaseRuleNodePath(databaseName, ruleType, new DatabaseRuleItem(ruleItemType, NodePathPattern.QUALIFIED_IDENTIFIER)), true, 1);
6666
}
6767
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/database/metadata/schema/SchemaMetaDataNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,6 @@ public SchemaMetaDataNodePath(final String databaseName, final String schemaName
4848
* @return created search criteria
4949
*/
5050
public static NodePathSearchCriteria createSchemaSearchCriteria(final String databaseName, final boolean containsChildPath) {
51-
return new NodePathSearchCriteria(new SchemaMetaDataNodePath(databaseName, NodePathPattern.IDENTIFIER), false, containsChildPath, 1);
51+
return new NodePathSearchCriteria(new SchemaMetaDataNodePath(databaseName, NodePathPattern.IDENTIFIER), containsChildPath, 1);
5252
}
5353
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/database/metadata/schema/TableMetaDataNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@ public TableMetaDataNodePath(final String databaseName, final String schemaName,
4747
* @return created search criteria
4848
*/
4949
public static NodePathSearchCriteria createTableSearchCriteria(final String databaseName, final String schemaName) {
50-
return new NodePathSearchCriteria(new TableMetaDataNodePath(databaseName, schemaName, NodePathPattern.IDENTIFIER), false, true, 1);
50+
return new NodePathSearchCriteria(new TableMetaDataNodePath(databaseName, schemaName, NodePathPattern.IDENTIFIER), true, 1);
5151
}
5252
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/database/metadata/schema/ViewMetaDataNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,6 @@ public ViewMetaDataNodePath(final String databaseName, final String schemaName,
4949
* @return created search criteria
5050
*/
5151
public static NodePathSearchCriteria createViewSearchCriteria(final String databaseName, final String schemaName) {
52-
return new NodePathSearchCriteria(new ViewMetaDataNodePath(databaseName, schemaName, NodePathPattern.IDENTIFIER), false, true, 1);
52+
return new NodePathSearchCriteria(new ViewMetaDataNodePath(databaseName, schemaName, NodePathPattern.IDENTIFIER), true, 1);
5353
}
5454
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/database/statistics/StatisticsDataNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,6 @@ public StatisticsDataNodePath(final String databaseName, final String schemaName
4747
* @return created search criteria
4848
*/
4949
public static NodePathSearchCriteria createRowUniqueKeySearchCriteria() {
50-
return new NodePathSearchCriteria(new StatisticsDataNodePath(NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER), false, false, 4);
50+
return new NodePathSearchCriteria(new StatisticsDataNodePath(NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER), false, 4);
5151
}
5252
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/database/statistics/StatisticsDatabaseNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,6 @@ public final class StatisticsDatabaseNodePath implements NodePath {
4141
* @return created search criteria
4242
*/
4343
public static NodePathSearchCriteria createDatabaseSearchCriteria(final boolean containsChildPath) {
44-
return new NodePathSearchCriteria(new StatisticsDatabaseNodePath(NodePathPattern.IDENTIFIER), false, containsChildPath, 1);
44+
return new NodePathSearchCriteria(new StatisticsDatabaseNodePath(NodePathPattern.IDENTIFIER), containsChildPath, 1);
4545
}
4646
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/database/statistics/StatisticsSchemaNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@ public StatisticsSchemaNodePath(final String databaseName, final String schemaNa
4646
* @return created search criteria
4747
*/
4848
public static NodePathSearchCriteria createSchemaSearchCriteria(final boolean containsChildPath) {
49-
return new NodePathSearchCriteria(new StatisticsSchemaNodePath(NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER), false, containsChildPath, 2);
49+
return new NodePathSearchCriteria(new StatisticsSchemaNodePath(NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER), containsChildPath, 2);
5050
}
5151
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/database/statistics/StatisticsTableNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,6 @@ public StatisticsTableNodePath(final String databaseName, final String schemaNam
4848
* @return created search criteria
4949
*/
5050
public static NodePathSearchCriteria createTableSearchCriteria(final boolean containsChildPath) {
51-
return new NodePathSearchCriteria(new StatisticsTableNodePath(NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER), false, containsChildPath, 3);
51+
return new NodePathSearchCriteria(new StatisticsTableNodePath(NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER, NodePathPattern.IDENTIFIER), containsChildPath, 3);
5252
}
5353
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/global/config/GlobalRuleNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,6 @@ public final class GlobalRuleNodePath implements NodePath {
4040
* @return created search criteria
4141
*/
4242
public static NodePathSearchCriteria createRuleTypeSearchCriteria() {
43-
return new NodePathSearchCriteria(new GlobalRuleNodePath(NodePathPattern.IDENTIFIER), false, true, 1);
43+
return new NodePathSearchCriteria(new GlobalRuleNodePath(NodePathPattern.IDENTIFIER), true, 1);
4444
}
4545
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/global/node/compute/label/LabelNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,6 @@ public final class LabelNodePath implements NodePath {
4040
* @return created search criteria
4141
*/
4242
public static NodePathSearchCriteria createInstanceIdSearchCriteria() {
43-
return new NodePathSearchCriteria(new LabelNodePath(NodePathPattern.IDENTIFIER), false, false, 1);
43+
return new NodePathSearchCriteria(new LabelNodePath(NodePathPattern.IDENTIFIER), false, 1);
4444
}
4545
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/global/node/compute/process/KillProcessTriggerNodePath.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public KillProcessTriggerNodePath() {
4444
* @return created search criteria
4545
*/
4646
public static NodePathSearchCriteria createInstanceIdSearchCriteria() {
47-
return new NodePathSearchCriteria(new KillProcessTriggerNodePath(), false, false, 1);
47+
return new NodePathSearchCriteria(new KillProcessTriggerNodePath(), false, 1);
4848
}
4949

5050
/**
@@ -53,6 +53,6 @@ public static NodePathSearchCriteria createInstanceIdSearchCriteria() {
5353
* @return created search criteria
5454
*/
5555
public static NodePathSearchCriteria createProcessIdSearchCriteria() {
56-
return new NodePathSearchCriteria(new KillProcessTriggerNodePath(), false, false, 2);
56+
return new NodePathSearchCriteria(new KillProcessTriggerNodePath(), false, 2);
5757
}
5858
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/global/node/compute/process/ShowProcessListTriggerNodePath.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public ShowProcessListTriggerNodePath() {
4444
* @return created search criteria
4545
*/
4646
public static NodePathSearchCriteria createInstanceIdSearchCriteria() {
47-
return new NodePathSearchCriteria(new ShowProcessListTriggerNodePath(), false, false, 1);
47+
return new NodePathSearchCriteria(new ShowProcessListTriggerNodePath(), false, 1);
4848
}
4949

5050
/**
@@ -53,6 +53,6 @@ public static NodePathSearchCriteria createInstanceIdSearchCriteria() {
5353
* @return created search criteria
5454
*/
5555
public static NodePathSearchCriteria createProcessIdSearchCriteria() {
56-
return new NodePathSearchCriteria(new ShowProcessListTriggerNodePath(), false, false, 2);
56+
return new NodePathSearchCriteria(new ShowProcessListTriggerNodePath(), false, 2);
5757
}
5858
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/global/node/compute/status/OnlineNodePath.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public OnlineNodePath() {
5151
* @return created search criteria
5252
*/
5353
public static NodePathSearchCriteria createInstanceTypeSearchCriteria() {
54-
return new NodePathSearchCriteria(new OnlineNodePath(), false, false, 1);
54+
return new NodePathSearchCriteria(new OnlineNodePath(), false, 1);
5555
}
5656

5757
/**
@@ -60,6 +60,6 @@ public static NodePathSearchCriteria createInstanceTypeSearchCriteria() {
6060
* @return created search criteria
6161
*/
6262
public static NodePathSearchCriteria createInstanceIdSearchCriteria() {
63-
return new NodePathSearchCriteria(new OnlineNodePath(), false, false, 2);
63+
return new NodePathSearchCriteria(new OnlineNodePath(), false, 2);
6464
}
6565
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/global/node/compute/status/StatusNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,6 @@ public final class StatusNodePath implements NodePath {
4040
* @return created search criteria
4141
*/
4242
public static NodePathSearchCriteria createInstanceIdSearchCriteria() {
43-
return new NodePathSearchCriteria(new StatusNodePath(NodePathPattern.IDENTIFIER), false, false, 1);
43+
return new NodePathSearchCriteria(new StatusNodePath(NodePathPattern.IDENTIFIER), false, 1);
4444
}
4545
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/global/node/compute/workerid/ComputeNodeWorkerIDNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,6 @@ public final class ComputeNodeWorkerIDNodePath implements NodePath {
4040
* @return created search criteria
4141
*/
4242
public static NodePathSearchCriteria createInstanceIdSearchCriteria() {
43-
return new NodePathSearchCriteria(new ComputeNodeWorkerIDNodePath(NodePathPattern.IDENTIFIER), false, false, 1);
43+
return new NodePathSearchCriteria(new ComputeNodeWorkerIDNodePath(NodePathPattern.IDENTIFIER), false, 1);
4444
}
4545
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/global/node/storage/QualifiedDataSourceNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,6 @@ public QualifiedDataSourceNodePath(final QualifiedDataSource qualifiedDataSource
4545
* @return created search criteria
4646
*/
4747
public static NodePathSearchCriteria createQualifiedDataSourceSearchCriteria() {
48-
return new NodePathSearchCriteria(new QualifiedDataSourceNodePath(NodePathPattern.QUALIFIED_IDENTIFIER), false, false, 1);
48+
return new NodePathSearchCriteria(new QualifiedDataSourceNodePath(NodePathPattern.QUALIFIED_IDENTIFIER), false, 1);
4949
}
5050
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/path/type/global/state/DatabaseListenerCoordinatorNodePath.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,6 @@ public final class DatabaseListenerCoordinatorNodePath implements NodePath {
4040
* @return created search criteria
4141
*/
4242
public static NodePathSearchCriteria createDatabaseSearchCriteria() {
43-
return new NodePathSearchCriteria(new DatabaseListenerCoordinatorNodePath(NodePathPattern.IDENTIFIER), false, false, 1);
43+
return new NodePathSearchCriteria(new DatabaseListenerCoordinatorNodePath(NodePathPattern.IDENTIFIER), false, 1);
4444
}
4545
}

mode/node/src/main/java/org/apache/shardingsphere/mode/node/rule/tuple/YamlRuleNodeTupleSwapperEngine.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ private boolean isNamedItem(final Field field) {
193193
private void setNamedItemFieldValue(final String databaseName, final YamlRuleConfiguration yamlRuleConfig,
194194
final String ruleType, final RuleNodeTuple tuple, final String itemType, final Field field) {
195195
DatabaseRuleNodePath databaseRuleNodePath = new DatabaseRuleNodePath(databaseName, ruleType, new DatabaseRuleItem(itemType, NodePathPattern.QUALIFIED_IDENTIFIER));
196-
Optional<String> itemValue = NodePathSearcher.find(tuple.getPath(), new NodePathSearchCriteria(databaseRuleNodePath, false, true, 1));
196+
Optional<String> itemValue = NodePathSearcher.find(tuple.getPath(), new NodePathSearchCriteria(databaseRuleNodePath, true, 1));
197197
if (!itemValue.isPresent()) {
198198
return;
199199
}
@@ -218,7 +218,7 @@ private void setNamedItemFieldValue(final String databaseName, final YamlRuleCon
218218
private void setUniqueItemFieldValue(final String databaseName, final YamlRuleConfiguration yamlRuleConfig,
219219
final String ruleType, final RuleNodeTuple tuple, final String itemType, final Field field) {
220220
DatabaseRuleNodePath databaseRuleNodePath = new DatabaseRuleNodePath(databaseName, ruleType, new DatabaseRuleItem(itemType));
221-
if (!NodePathSearcher.isMatchedPath(tuple.getPath(), new NodePathSearchCriteria(databaseRuleNodePath, false, true, 1))) {
221+
if (!NodePathSearcher.isMatchedPath(tuple.getPath(), new NodePathSearchCriteria(databaseRuleNodePath, true, 1))) {
222222
return;
223223
}
224224
if (field.getType().equals(Collection.class)) {

mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/listener/type/DatabaseMetaDataChangedListener.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ private boolean isSubscribed(final DatabaseChangedHandler handler, final String
8989
return new VersionNodePath(handler.getSubscribedNodePath(databaseName)).isActiveVersionPath(event.getKey());
9090
}
9191
if (handler instanceof DatabaseNodeValueChangedHandler) {
92-
return NodePathSearcher.isMatchedPath(event.getKey(), new NodePathSearchCriteria(handler.getSubscribedNodePath(databaseName), false, false, 1));
92+
return NodePathSearcher.isMatchedPath(event.getKey(), new NodePathSearchCriteria(handler.getSubscribedNodePath(databaseName), false, 1));
9393
}
9494
return false;
9595
}

0 commit comments

Comments
 (0)