Skip to content

Commit 9715c29

Browse files
authored
Refactor ComputeNodeLabelChangedHandler (#34937)
1 parent 27be65e commit 9715c29

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

mode/type/cluster/core/src/main/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/global/node/ComputeNodeLabelChangedHandler.java

+2-4
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
package org.apache.shardingsphere.mode.manager.cluster.dispatch.handler.global.node;
1919

2020
import com.google.common.base.Strings;
21-
import org.apache.shardingsphere.infra.instance.ComputeNodeInstanceContext;
2221
import org.apache.shardingsphere.infra.util.yaml.YamlEngine;
2322
import org.apache.shardingsphere.mode.event.DataChangedEvent;
2423
import org.apache.shardingsphere.mode.event.DataChangedEvent.Type;
@@ -54,8 +53,7 @@ public void handle(final ContextManager contextManager, final DataChangedEvent e
5453

5554
@SuppressWarnings("unchecked")
5655
private void handle(final ContextManager contextManager, final DataChangedEvent event, final String instanceId) {
57-
ComputeNodeInstanceContext computeNodeInstanceContext = contextManager.getComputeNodeInstanceContext();
58-
// TODO labels may be empty
59-
computeNodeInstanceContext.updateLabels(instanceId, Strings.isNullOrEmpty(event.getValue()) ? new ArrayList<>() : YamlEngine.unmarshal(event.getValue(), Collection.class));
56+
contextManager.getComputeNodeInstanceContext().updateLabels(
57+
instanceId, Strings.isNullOrEmpty(event.getValue()) ? new ArrayList<>() : YamlEngine.unmarshal(event.getValue(), Collection.class));
6058
}
6159
}

0 commit comments

Comments
 (0)