Skip to content

Commit f5b86a0

Browse files
authored
Fix sonar issue on ClusterMetaDataManagerPersistServiceTest (#34987)
1 parent ce1f59c commit f5b86a0

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/persist/service/ClusterMetaDataManagerPersistServiceTest.java

+5-6
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@
2323
import org.apache.shardingsphere.infra.metadata.database.rule.RuleMetaData;
2424
import org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereSchema;
2525
import org.apache.shardingsphere.infra.metadata.database.schema.model.ShardingSphereTable;
26-
import org.apache.shardingsphere.mode.manager.cluster.persist.coordinator.database.ClusterDatabaseListenerPersistCoordinator;
2726
import org.apache.shardingsphere.mode.manager.cluster.persist.coordinator.database.ClusterDatabaseListenerCoordinatorType;
27+
import org.apache.shardingsphere.mode.manager.cluster.persist.coordinator.database.ClusterDatabaseListenerPersistCoordinator;
2828
import org.apache.shardingsphere.mode.metadata.manager.MetaDataContextManager;
2929
import org.apache.shardingsphere.mode.metadata.persist.MetaDataPersistFacade;
3030
import org.apache.shardingsphere.mode.spi.repository.PersistRepository;
@@ -40,7 +40,6 @@
4040
import org.mockito.internal.configuration.plugins.Plugins;
4141
import org.mockito.junit.jupiter.MockitoExtension;
4242

43-
import java.sql.SQLException;
4443
import java.util.Collections;
4544
import java.util.Properties;
4645

@@ -142,29 +141,29 @@ void assertAlterSingleRuleConfiguration() {
142141
}
143142

144143
@Test
145-
void assertAlterNullRuleConfiguration() throws SQLException {
144+
void assertAlterNullRuleConfiguration() {
146145
metaDataManagerPersistService.alterRuleConfiguration(new ShardingSphereDatabase("foo_db", mock(), mock(), mock(), Collections.emptyList()), null);
147146
verify(metaDataPersistFacade.getDatabaseRuleService(), times(0)).persist(eq("foo_db"), any());
148147
}
149148

150149
@Test
151150
@Disabled
152-
void assertAlterRuleConfiguration() throws SQLException {
151+
void assertAlterRuleConfiguration() {
153152
RuleConfiguration ruleConfig = new SingleRuleConfiguration();
154153
when(metaDataContextManager.getMetaDataContexts().getMetaData().getDatabase("foo_db").getProtocolType()).thenReturn(new MockedDatabaseType());
155154
metaDataManagerPersistService.alterRuleConfiguration(new ShardingSphereDatabase("foo_db", new MockedDatabaseType(), mock(), mock(), Collections.emptyList()), ruleConfig);
156155
verify(metaDataPersistFacade.getDatabaseRuleService()).persist("foo_db", Collections.singleton(ruleConfig));
157156
}
158157

159158
@Test
160-
void assertRemoveNullRuleConfigurationItem() throws SQLException {
159+
void assertRemoveNullRuleConfigurationItem() {
161160
metaDataManagerPersistService.removeRuleConfigurationItem(new ShardingSphereDatabase("foo_db", mock(), mock(), mock(), Collections.emptyList()), null);
162161
verify(metaDataPersistFacade.getDatabaseRuleService(), times(0)).delete(eq("foo_db"), anyCollection());
163162
}
164163

165164
@Test
166165
@Disabled
167-
void assertRemoveRuleConfigurationItem() throws SQLException {
166+
void assertRemoveRuleConfigurationItem() {
168167
RuleConfiguration ruleConfig = new SingleRuleConfiguration();
169168
metaDataManagerPersistService.removeRuleConfigurationItem(new ShardingSphereDatabase("foo_db", mock(), mock(), mock(), Collections.emptyList()), ruleConfig);
170169
verify(metaDataPersistFacade.getDatabaseRuleService()).delete("foo_db", Collections.singleton(ruleConfig));

0 commit comments

Comments
 (0)