Fix typing on iOS

Author: bootstraponline

ios_tests/lib/ios/specs/ios/element/textfield.rb

@@ -1,4 +1,5 @@
 # encoding: utf-8
+# rake ios[ios/element/textfield]
 describe 'ios/element/textfield' do
   before_first { go_to_textfields }
   after_last { set_wait 30 }
@@ -41,6 +42,31 @@ def enter_password
     textfield_exact(enter_password).text.must_equal enter_password
   end
 
+  def keyboard_exists?
+    !! ignore { wait_true(3) { execute_script 'au.mainApp().keyboard().type() !== "UIAElementNil"' } }
+  end
+
+  def keyboard_must_not_exist
+    keyboard_exists?.must_equal false
+  end
+
+  def keyboard_must_exist
+    keyboard_exists?.must_equal true
+  end
+
+  t 'textfield type' do
+    # Regular send keys triggers the keyboard and doesn't dismiss
+    keyboard_must_not_exist
+    textfield(1).send_keys 'ok'
+    keyboard_must_exist
+
+    # type will dismiss the keyboard
+    message = 'type test type'
+    textfield(1).type message
+    keyboard_must_not_exist
+    textfield(1).text.must_equal message
+  end
+
   def must_raise_no_element &block
     proc { block.call }.must_raise Selenium::WebDriver::Error::NoSuchElementError
   end

lib/appium_lib/ios/patch.rb

@@ -22,13 +22,23 @@ def type text
 -10 to ensure we're not going outside the window bounds.
 
 Swiping inside the keyboard will not dismiss it.
+
+var startY = au.mainApp().keyboard().rect().origin.y - 10;
+var endY = au.mainWindow().rect().size.height - 10;
+au.flickApp(0, startY, 0, endY);
+
+The above logic has been accepted as part of appium's au.hideKeyboard
+https://github.com/appium/appium-uiauto/blob/dbeb4eedbdea2104751a0d547ac9b2894e0dc567/uiauto/appium/app.js#L902
+
+If the 'Done' key exists then that should be pressed to dismiss the keyboard
+because swiping to dismiss works only if such key doesn't exist.
 =end
           # type
           $driver.execute_script %(au.getElement('#{self.ref}').setValue('#{text}');)
 
           $driver.ignore {
-            # wait 5 seconds for keyboard. if the textfield is disabled then
-            # setValue will work, however the keyboard will never display
+            # wait 5 seconds for a wild keyboard to appear. if the textfield is disabled
+            # then setValue will work, however the keyboard will never display
             # because users are normally not allowed to type into it.
             $driver.wait_true(5) do
               $driver.execute_script %(au.mainApp().keyboard().type() !== 'UIAElementNil')
@@ -37,13 +47,16 @@ def type text
             # dismiss keyboard
             js = <<-JS
             if (au.mainApp().keyboard().type() !== "UIAElementNil") {
-              var startY = au.mainApp().keyboard().rect().origin.y - 10;
-              var endY = au.mainWindow().rect().size.height - 10;
-              au.flickApp(0, startY, 0, endY);
+              au.hideKeyboard('Done');
             }
             JS
 
             $driver.execute_script js
+
+            # wait 5 seconds for keyboard to go away
+            $driver.wait_true(5) do
+              $driver.execute_script %(au.mainApp().keyboard().type() === 'UIAElementNil')
+            end
           }
         end # def type
       end # Selenium::WebDriver::Element.class_eval