Merge pull request #324 from appium/rubocop

Rubocop

Author: bootstraponline

.rubocop.yml

@@ -3,6 +3,8 @@ Metrics/LineLength:
   Max: 125
 Metrics/MethodLength:
   Max: 30
+Metrics/ClassLength:
+  Enabled: false
 Metrics/CyclomaticComplexity:
   Enabled: false
 Metrics/PerceivedComplexity:
@@ -20,3 +22,7 @@ Style/ConstantName:
 # blocked on https://github.com/appium/ruby_lib/issues/312
 Style/GlobalVars:
   Enabled: false
+Style/AccessorMethodName:
+  Enabled: false
+Style/DoubleNegation:
+  Enabled: false

lib/appium_lib/android/helper.rb

@@ -3,11 +3,7 @@ module Android
     # @private
     # http://nokogiri.org/Nokogiri/XML/SAX.html
     class AndroidElements < Nokogiri::XML::SAX::Document
-      attr_reader :result, :keys, :instance
-
-      def filter
-        @filter
-      end
+      attr_reader :result, :keys, :instance, :filter
 
       # convert to string to support symbols
       def filter=(value)

lib/appium_lib/common/helper.rb

@@ -158,9 +158,7 @@ def resolve_id(id)
     end
 
     class HTMLElements < Nokogiri::XML::SAX::Document
-      def filter
-        @filter
-      end
+      attr_reader :filter
 
       # convert to string to support symbols
       def filter=(value)

lib/appium_lib/common/patch.rb

@@ -121,7 +121,9 @@ def raw_execute(command, opts = {}, command_hash = nil)
 end
 
 # Print Appium's origValue error messages.
-class Selenium::WebDriver::Remote::Response # rubocop:disable Style/ClassAndModuleChildren
+# rubocop:disable Style/ClassAndModuleChildren
+# rubocop:disable Style/AndOr
+class Selenium::WebDriver::Remote::Response
   # @private
   def error_message
     val = value

lib/appium_lib/device/touch_actions.rb

@@ -79,7 +79,7 @@ def release(opts = nil)
     # @option opts [integer] :fingers how many fingers to tap with (Default 1)
     def tap(opts)
       opts[:count]       = opts.delete(:fingers) if opts[:fingers]
-      opts_with_defaults = { count: 1 }.merge opts
+      opts[:count]     ||= 1
       args               = args_with_ele_ref opts
       chain_method(:tap, args)
     end

lib/appium_lib/driver.rb

@@ -465,7 +465,7 @@ def driver_quit
     # @return [Selenium::WebDriver] the new global driver
     def start_driver
       @client ||= Selenium::WebDriver::Remote::Http::Default.new
-      @client.timeout = 999999
+      @client.timeout = 999_999
 
       begin
         driver_quit

lib/appium_lib/rails/duplicable.rb

@@ -1,5 +1,5 @@
 # rubocop:disable Style/BlockComments
-
+# rubocop:disable Lint/HandleExceptions
 # https://github.com/rails/rails/blob/e120d21211f9644e9b832e51ba7aa6c45448b782/activesupport/lib/active_support/core_ext/object/duplicable.rb
 =begin
 Copyright (c) 2005-2011 David Heinemeier Hansson