feat: bump ruby version (#887)

* feat: bump ruby version

* relevant changes

Author: KazuCocoa

.github/workflows/rubocop.yml

@@ -11,7 +11,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ruby: [2.2, 2.3, 2.4, 2.5, 2.6, 2.7]
+        ruby: [2.4, 2.5, 2.6, 2.7]
 
     runs-on: ubuntu-latest
 

.rubocop.yml

@@ -1,5 +1,5 @@
 AllCops:
-  TargetRubyVersion: 2.3
+  TargetRubyVersion: 2.4
 Metrics/LineLength:
   Max: 128
 Metrics/MethodLength:
@@ -25,12 +25,6 @@ Style/GlobalVars:
   Enabled: false
 Style/PercentLiteralDelimiters:
   Enabled: false
-# Can use over Ruby2.3
-Style/SafeNavigation:
-  Enabled: false
-# Can use over Ruby2.3
-Style/NumericPredicate:
-  Enabled: false
 Style/CommentedKeyword:
   Enabled: false
 Naming/AccessorMethodName:

CHANGELOG.md

@@ -4,6 +4,11 @@ Commit based release not is [release_notes.md](./release_notes.md)
 Release tags are https://github.com/appium/ruby_lib/releases .
 
 ## Unreleased
+
+Bump supported Ruby version to 2.4+
+
+[related changes](https://github.com/appium/ruby_lib_core/blob/master/CHANGELOG.md#400---2020-12-19) in ruby_lib_core.
+
 ### 1. Enhancements
 
 ### 2. Bug fixes

android_tests/lib/run.rb

@@ -101,6 +101,6 @@ def start_driver(caps)
 end
 
 # Exit after tests.
-Minitest.after_run { $driver.x if $driver }
+Minitest.after_run { $driver&.x }
 # Run Minitest. Provide test file array for tracing.
 Minitest.run_specs(trace: trace_files)

appium_lib.gemspec

@@ -1,7 +1,7 @@
 require_relative 'lib/appium_lib/version'
 
 Gem::Specification.new do |s|
-  s.required_ruby_version = '>= 2.2' # rubocop:disable Gemspec/RequiredRubyVersion
+  s.required_ruby_version = '>= 2.4'
 
   s.name          = 'appium_lib'
   s.version       = Appium::VERSION
@@ -14,7 +14,7 @@ Gem::Specification.new do |s|
   s.homepage      = 'https://github.com/appium/ruby_lib' # published as appium_lib
   s.require_paths = ['lib']
 
-  s.add_runtime_dependency 'appium_lib_core', '~> 3.3'
+  s.add_runtime_dependency 'appium_lib_core', '~> 4.0'
   s.add_runtime_dependency 'nokogiri', '~> 1.8', '>= 1.8.1'
   s.add_runtime_dependency 'tomlrb', '~> 1.1'
 

lib/appium_lib/android/element/button.rb

@@ -60,9 +60,9 @@ def last_button
       # uiautomator index doesn't support last
       # and it's 0 indexed
       button_index = tags(BUTTON).length
-      button_index -= 1 if button_index > 0
+      button_index -= 1 if button_index.positive?
       image_button_index = tags(IMAGE_BUTTON).length
-      image_button_index -= 1 if image_button_index > 0
+      image_button_index -= 1 if image_button_index.positive?
 
       find_element :uiautomator,
                    _button_visible_selectors(button_index: button_index,

lib/appium_lib/android/espresso/element/button.rb

@@ -63,9 +63,9 @@ def last_button
           # uiautomator index doesn't support last
           # and it's 0 indexed
           button_index = tags(::Appium::Android::BUTTON).length
-          button_index -= 1 if button_index > 0
+          button_index -= 1 if button_index.positive?
           image_button_index = tags(::Appium::Android::IMAGE_BUTTON).length
-          image_button_index -= 1 if image_button_index > 0
+          image_button_index -= 1 if image_button_index.positive?
 
           _button_visible_selectors_xpath(button_index: button_index,
                                           image_button_index: image_button_index)

lib/appium_lib/android/uiautomator2/element/button.rb

@@ -60,9 +60,9 @@ def last_button
           # uiautomator index doesn't support last
           # and it's 0 indexed
           button_index = tags(::Appium::Android::Button).length
-          button_index -= 1 if button_index > 0
+          button_index -= 1 if button_index.positive?
           image_button_index = tags(::Appium::Android::ImageButton).length
-          image_button_index -= 1 if image_button_index > 0
+          image_button_index -= 1 if image_button_index.positive?
 
           elements = find_elements :uiautomator,
                                    _button_visible_selectors(button_index: button_index,

lib/appium_lib/driver.rb

@@ -163,9 +163,8 @@ def initialize(opts = {}, global_driver = nil)
         global_driver = true # if global_driver is nil, then global_driver must be default value.
       end
 
-      if global_driver
-        $driver.driver_quit if $driver
-      end
+      $driver&.driver_quit if global_driver
+
       raise 'opts must be a hash' unless opts.is_a? Hash
 
       @core = ::Appium::Core.for(opts)

lib/appium_lib/ios/common/helper.rb

@@ -76,7 +76,7 @@ def page(opts = {})
       source = get_source
 
       # current_context may be nil which breaks start_with
-      if current_context && current_context.start_with?('WEBVIEW')
+      if current_context&.start_with?('WEBVIEW')
         parser = @android_html_parser ||= Nokogiri::HTML::SAX::Parser.new(Appium::Common::HTMLElements.new)
         parser.document.reset
         parser.document.filter = class_name

readme.md

@@ -21,7 +21,7 @@ We can avoid the class driver with current `ruby_lib`, but if you'd like to impl
 # Setup
 ## Requirement
 - [Appium](https://github.com/appium/appium#requirements)
-- Ruby: 2.2+
+- Ruby: 2.4+
 
 ### Ruby Lib and Appium
 - Ruby library version over `9.8.0` requires Appium over `1.8`