Improve performance for button/s and text/s (#442)

* don't use xpath for button and static text

* ignore down or up cases

Author: KazuCocoa

ios_tests/lib/ios/specs/ios/element/button.rb

@@ -29,7 +29,7 @@ def gray
 
   t 'buttons' do
     exp = ['Back', 'Back', 'Gray', 'Right pointing arrow']
-    exp.concat ['Custom Text', 'More info', 'More info', 'More info', 'Add contact'] if UI::Inventory.xcuitest?
+    exp.concat ['Add contact'] if UI::Inventory.xcuitest?
 
     target_buttons = buttons('a')
     target_buttons.map(&:name).must_equal exp

lib/appium_lib/ios/element/button.rb

@@ -18,7 +18,7 @@ def button(value)
       return ele_index button_class, value if value.is_a? Numeric
 
       if automation_name_is_xcuitest?
-        find_ele_by_attr_include button_class, '*', value
+        _raise_error_if_no_element buttons(value).first
       else
         ele_by_json_visible_contains button_class, value
       end
@@ -32,7 +32,8 @@ def buttons(value = false)
       return tags button_class unless value
 
       if automation_name_is_xcuitest?
-        find_eles_by_attr_include button_class, '*', value
+        elements = tags button_class
+        _elements_include elements, value
       else
         eles_by_json_visible_contains button_class, value
       end
@@ -57,7 +58,7 @@ def last_button
     # @return [UIAButton|XCUIElementTypeButton]
     def button_exact(value)
       if automation_name_is_xcuitest?
-        find_ele_by_attr button_class, '*', value
+        _raise_error_if_no_element buttons_exact(value).first
       else
         ele_by_json_visible_exact button_class, value
       end
@@ -68,7 +69,8 @@ def button_exact(value)
     # @return [Array<UIAButton|XCUIElementTypeButton>]
     def buttons_exact(value)
       if automation_name_is_xcuitest?
-        find_eles_by_attr button_class, '*', value
+        elements = tags button_class
+        _elements_exact elements, value
       else
         eles_by_json_visible_exact button_class, value
       end

lib/appium_lib/ios/element/generic.rb

@@ -43,5 +43,28 @@ def finds_exact(value)
         eles_by_json_visible_exact '*', value
       end
     end
+
+    private
+
+    def _raise_error_if_no_element(element)
+      raise ::Selenium::WebDriver::Error::NoSuchElementError if element.nil?
+      element
+    end
+
+    def _elements_include(elements, value)
+      return [] if elements.empty?
+      elements.select do |element|
+        name = element.name
+        name.nil? ? false : name.downcase.include?(value.downcase)
+      end
+    end
+
+    def _elements_exact(elements, value)
+      return [] if elements.empty?
+      elements.select do |element|
+        name = element.name
+        name.nil? ? false : name.casecmp(value).zero?
+      end
+    end
   end # module Ios
 end # module Appium

lib/appium_lib/ios/element/text.rb

@@ -17,7 +17,7 @@ def text(value)
       return ele_index static_text_class, value if value.is_a? Numeric
 
       if automation_name_is_xcuitest?
-        find_ele_by_attr_include static_text_class, '*', value
+        _raise_error_if_no_element texts(value).first
       else
         ele_by_json_visible_contains static_text_class, value
       end
@@ -31,7 +31,8 @@ def texts(value = false)
       return tags static_text_class unless value
 
       if automation_name_is_xcuitest?
-        find_eles_by_attr_include static_text_class, '*', value
+        elements = tags static_text_class
+        _elements_include elements, value
       else
         eles_by_json_visible_contains static_text_class, value
       end
@@ -54,7 +55,7 @@ def last_text
     # @return [UIAStaticText|XCUIElementTypeStaticText]
     def text_exact(value)
       if automation_name_is_xcuitest?
-        find_ele_by_attr static_text_class, '*', value
+        _raise_error_if_no_element texts_exact(value).first
       else
         ele_by_json_visible_exact static_text_class, value
       end
@@ -65,7 +66,8 @@ def text_exact(value)
     # @return [Array<UIAStaticText|XCUIElementTypeStaticText>]
     def texts_exact(value)
       if automation_name_is_xcuitest?
-        find_eles_by_attr static_text_class, '*', value
+        elements = tags static_text_class
+        _elements_exact elements, value
       else
         eles_by_json_visible_exact static_text_class, value
       end