Don't try and hide the keyboard after .type

Author: bootstraponline

lib/appium_lib/ios/helper.rb

@@ -379,12 +379,18 @@ def eles_by_json_visible_exact element, value
     # @return [void]
     def hide_ios_keyboard close_key='Done'
 =begin
+todo: there are many various ways to hide the keyboard that work in different
+app specific circumstances. webview keyboard will require a window.tap for example.
+
 Find the top left corner of the keyboard and move up 10 pixels (origin.y - 10)
 now swipe down until the end of the window - 10 pixels.
 -10 to ensure we're not going outside the window bounds.
 
 Swiping inside the keyboard will not dismiss it.
 
+If the 'Done' key exists then that should be pressed to dismiss the keyboard
+because swiping to dismiss works only if such key doesn't exist.
+
 Don't use window.tap. See https://github.com/appium/appium-uiauto/issues/28
 =end
       dismiss_keyboard = (<<-JS).strip

lib/appium_lib/ios/patch.rb

@@ -14,27 +14,8 @@ def label
 
         # Cross platform way of entering text into a textfield
         def type text
-          # enter text then tap window to hide the keyboard.
-=begin
-Find the top left corner of the keyboard and move up 10 pixels (origin.y - 10)
-now swipe down until the end of the window - 10 pixels.
--10 to ensure we're not going outside the window bounds.
-
-Swiping inside the keyboard will not dismiss it.
-
-var startY = au.mainApp().keyboard().rect().origin.y - 10;
-var endY = au.mainWindow().rect().size.height - 10;
-au.flickApp(0, startY, 0, endY);
-
-The above logic has been accepted as part of appium's au.hideKeyboard
-https://github.com/appium/appium-uiauto/blob/dbeb4eedbdea2104751a0d547ac9b2894e0dc567/uiauto/appium/app.js#L902
-
-If the 'Done' key exists then that should be pressed to dismiss the keyboard
-because swiping to dismiss works only if such key doesn't exist.
-=end
           # type
           $driver.execute_script %(au.getElement('#{self.ref}').setValue('#{text}');)
-          $driver.hide_ios_keyboard
         end # def type
       end # Selenium::WebDriver::Element.class_eval
     end # def patch_webdriver_element