Rubocop - Style/RegexpLiteral

Author: JaniJegoroff

lib/appium_lib/android/helper.rb

@@ -91,7 +91,7 @@ def _fix_android_native_source(source)
       # <android.app.ActionBar  $  Tab
 
       # find each closing tag that contains a dollar sign.
-      source.scan(/<\/([^>]*\$[^>]*)>/).flatten.uniq.each do |problem_tag|
+      source.scan(%r(/<\/([^>]*\$[^>]*)>/)).flatten.uniq.each do |problem_tag|
         # "android.app.ActionBar$Tab"
         before, after = problem_tag.split('$')
         before.strip!
@@ -106,7 +106,7 @@ def _fix_android_native_source(source)
         #  <android.app.ActionBar$Tab   => <android.app.ActionBar.Tab
         # </android.app.ActionBar$Tab> => </android.app.ActionBar.Tab>
         source = source.gsub(/<#{before}\s*\$\s*#{after}/, "<#{fixed}").
-          gsub(/<\/#{before}\s*\$\s*#{after}>/, "</#{fixed}>")
+          gsub(%r(/<\/#{before}\s*\$\s*#{after}>/), "</#{fixed}>")
       end
 
       source
@@ -170,7 +170,7 @@ def current_app
     # @private
     # noinspection RubyArgCount
     def _parse_current_app_line(line)
-      match = line.match(/ ([^\/ ]+\/[^ }]+)[ }]/)
+      match = line.match(%r(/ ([^\/ ]+\/[^ }]+)[ }]/))
       return nil unless match && match[1]
 
       pair = match[1].split '/'
@@ -274,7 +274,7 @@ def _resourceId(string, on_match)
       # [^\/]+          - type is made up of at least one non-/ characters
       # \\/             - / ends the type and starts the name
       # [\S]+$          - the name contains at least one non-space character and then the line is ended
-      resource_id = /^[a-zA-Z_][a-zA-Z0-9\._]*:[^\/]+\/[\S]+$/
+      resource_id = %r(/^[a-zA-Z_][a-zA-Z0-9\._]*:[^\/]+\/[\S]+$/)
       string.match(resource_id) ? on_match : ''
     end
 

lib/appium_lib/common/patch.rb

@@ -79,7 +79,7 @@ def raw_execute(command, opts = {}, command_hash = nil)
       end
 
       # convert /// into /
-      path.gsub! /\/+/, '/'
+      path.gsub! %r(/\/+/), '/'
 
       # change path from session/efac972c-941a-499c-803c-d7d008749/execute
       # to /execute

lib/appium_lib/driver.rb

@@ -404,14 +404,14 @@ def self.absolute_app_path(opts)
       # Sauce storage API. http://saucelabs.com/docs/rest#storage
       return app_path if app_path.start_with? 'sauce-storage:'
       return app_path if app_path.match(/^http/) # public URL for Sauce
-      if app_path.match(/^(\/|[a-zA-Z]:)/) # absolute file path
+      if app_path.match(%r(/^(\/|[a-zA-Z]:)/)) # absolute file path
         app_path = File.expand_path app_path unless File.exist? app_path
         raise "App doesn't exist. #{app_path}" unless File.exist? app_path
         return app_path
       end
 
       # if it doesn't contain a slash then it's a bundle id
-      return app_path unless app_path.match(/[\/\\]/)
+      return app_path unless app_path.match(%r(/[\/\\]/))
 
       # relative path that must be expanded.
       # absolute_app_path is called from load_appium_txt