Fix tests for xcuitest strategy (#408)

* switch previous version or xcuitest version

* use class for tag to make it stable

* add comments and revert js commands for appium

* fix and comment out
use accessibiliyt id as id and skip some tests

* use id directory

* raise error when notimplemented error

* move id test

* raise error when xcuitests is selected under appium1.6.0

* fix pinch and zoom for xcuitest

* fix robocop

* remove unused hide keyboard

* fix tests

* update comments and required version

* add error and documentations

* get status by WebDriverAgent directly and available custom url for WDA

* use capability's platformVersion instead of call WDA directly

* arrange some comments

* make accesable each class name

Author: KazuCocoa

android_tests/lib/android/specs/common/device_touchaction.rb

@@ -2,10 +2,10 @@
 describe 'common/device_touchaction' do
   t 'action_chain' do
     wait do
-      e = find_element(:name, 'Accessibility')
+      e = text('Accessibility')
       Appium::TouchAction.new.press(element: e, x: 0.5, y: 0.5).release(element: e).perform
     end
-    wait { find_element(:name, 'Custom View') }
+    wait { text('Custom View') }
     back
     wait { text_exact 'NFC' }
   end

docs/index_paths.md

@@ -8,14 +8,14 @@ that appium calculates when the page source is requested. Note this is not the s
 The index path can be used by calling [getElementByIndexPath]( https://github.com/appium/appium-uiauto/blob/af1befa8208074686cd38b845ddefabc057106fc/uiauto/lib/mechanic-ext/xpath-ext.js#L239):
 
 ```ruby
-# ruby example
+# ruby example # For Appium(automation name), not XCUITest
 execute_script('$.getElementByIndexPath("/0/1/1/10/0")').text # Alerts
 ```
 
 Internally what happens is `/0/1/1/10/0` is transformed into `1/1/10/0` and executed as follows:
 
 ```ruby
-# ruby example
+# ruby example # For Appium(automation name), not XCUITest
 execute_script('$.mainApp().elements()[1].elements()[1].elements()[10].elements()[0]').text # Alerts
 ```
 

ios_tests/appium.txt

@@ -2,7 +2,7 @@
 platformName = "ios"
 platformVersion = "10.1"
 deviceName ="iPhone Simulator"
-automationName = 'xcuitest'
+automationName = 'XCUITest'
 app = "./UICatalog.app"
 
 [appium_lib]

ios_tests/lib/common.rb

@@ -18,15 +18,13 @@ def leave_textfields
 def go_to_textfields
   screen.must_equal catalog
   wait_true do
-    text('textfield').click
+    UI::Inventory.xcuitest? ? find_element(:name, 'TextFields').click : text('textfield').click
     screen == 'TextFields' # wait for screen transition
   end
-
-  screen.must_equal 'TextFields'
 end
 
 def screen
-  $driver.find_element(:class, 'UIANavigationBar').name
+  $driver.find_element(:class, UI::Inventory.navbar).name
 end
 
 def catalog
@@ -35,14 +33,10 @@ def catalog
 
 module UI
   module Inventory
-    private
-
     def self.xcuitest?
-      $driver.automation_name && $driver.automation_name == 'xcuitest'
+      $driver.automation_name_is_xcuitest?
     end
 
-    public
-
     def self.navbar
       if xcuitest?
         'XCUIElementTypeNavigationBar'

ios_tests/lib/ios/specs/common/helper.rb

@@ -137,17 +137,20 @@ def uibutton_text
 
   t 'find_eles_by_attr_include' do
     ele_count = find_eles_by_attr_include(UI::Inventory.static_text, :name, 'e').length
-    ele_count.must_equal 20
+    expected = UI::Inventory.xcuitest? ? 20 : 19
+    ele_count.must_equal expected
   end
 
   t 'first_ele' do
     first_ele(UI::Inventory.static_text).name.must_equal 'UICatalog'
   end
 
   t 'last_ele' do
+    expected = UI::Inventory.xcuitest? ? 'Shows UIViewAnimationTransitions' : 'Transitions'
+
     el = last_ele(UI::Inventory.static_text)
-    el.text.must_equal 'Shows UIViewAnimationTransitions'
-    el.name.must_equal 'Shows UIViewAnimationTransitions'
+    el.text.must_equal expected
+    el.name.must_equal expected
   end
 
   # t 'source' do # tested by get_source
@@ -181,10 +184,7 @@ def uibutton_text
   end
 
   # TODO: write tests
-  # get_page_class
   # page_class
-  # tag
-  # tags
   # px_to_window_rel
   # lazy_load_strings
   # xml_keys

ios_tests/lib/ios/specs/device/device.rb

@@ -18,6 +18,8 @@ def go_back
   end
 
   t 'lock' do
+    fail NotImplementedError, "XCUITest(Appium1.6.2) doesn't support yet" if UI::Inventory.xcuitest?
+
     lock 5
     tag(UI::Inventory.button).name.must_equal 'SlideToUnlock'
 
@@ -32,11 +34,15 @@ def go_back
   end
 
   t 'app_installed' do
+    fail NotImplementedError, "XCUITest(Appium1.6.2) doesn't support yet" if UI::Inventory.xcuitest?
+
     installed = app_installed? 'Derrp'
     installed.must_equal false
   end
 
   t 'shake' do
+    fail NotImplementedError, "XCUITest(Appium1.6.2) doesn't support yet" if UI::Inventory.xcuitest?
+
     shake
   end
 
@@ -75,23 +81,23 @@ def go_back
   end
 
   t 'swipe' do
-    swipe start_x: 75, start_y: 500, delta_x: 75, delta_y: 0, duration: 800
-  end
-
-  t 'pinch & zoom' do
-    wait { id('ImagesExplain').click }
-    # both of these appear to do nothing on iOS 8
-    zoom 200
-    pinch 75
-    go_back
+    swipe start_x: 75, start_y: 500, delta_x: 0, delta_y: -500, duration: 800
   end
 
   t 'pull_file' do
+    # Selenium::WebDriver::Error::UnknownError: An unknown server-side error occurred while processing the command.
+    # Original error: Cannot read property 'getDir' of undefined
+    fail NotImplementedError, "XCUITest(Appium1.6.2) doesn't support yet" if UI::Inventory.xcuitest?
+
     read_file = pull_file 'Library/AddressBook/AddressBook.sqlitedb'
     read_file.start_with?('SQLite format').must_equal true
   end
 
   t 'pull_folder' do
+    # Selenium::WebDriver::Error::UnknownError: An unknown server-side error occurred while processing the command.
+    # Original error: Cannot read property 'getDir' of undefined
+    fail NotImplementedError, "XCUITest(Appium1.6.2) doesn't support yet" if UI::Inventory.xcuitest?
+
     data = pull_folder 'Library/AddressBook'
     data.length.must_be :>, 1
   end

ios_tests/lib/ios/specs/device/multi_touch.rb

@@ -1,5 +1,26 @@
+# rake ios[device/multi_touch]
 describe 'device/multi_touch' do
-  t {} # place holder test
+  def before_first
+    screen.must_equal catalog
+  end
+
+  # go back to the main page
+  def go_back
+    back
+    wait { !exists { id 'ArrowButton'  } } # successfully transitioned back
+  end
+
+  t 'before_first' do
+    before_first
+  end
+
+  t 'pinch & zoom' do
+    wait { id('Images').click }
+    # both of these appear to do nothing on iOS 8
+    zoom 200
+    pinch 75
+    go_back
+  end
 end
 
 # TODO: write tests

ios_tests/lib/ios/specs/device/touch_actions.rb

@@ -1,7 +1,12 @@
+# rake ios[device/touch_actions]
 describe 'device/touch_actions' do
+  def after_last
+    back_click
+  end
+
   t 'swipe_default_duration' do
     wait_true do
-      text('pickers').click
+      wait { UI::Inventory.xcuitest? ? find_element(:name, 'Pickers').click : text('pickers').click }
       screen == 'Pickers'
     end
 
@@ -11,9 +16,13 @@
     size = picker.size.to_h
     start_x = loc[:x] + size[:width] / 2
     start_y = loc[:y] + size[:height] / 2
-    swipe start_x: start_x, start_y: start_y, delta_x: start_x, delta_y: - 50
+    swipe start_x: start_x, start_y: start_y, delta_x: 0, delta_y: - 50
     ele_index(UI::Inventory.static_text, 2).text.must_equal 'Chris Armstrong - 0'
   end
+
+  t 'after_last' do
+    after_last
+  end
 end
 
 # TODO: write tests

ios_tests/lib/ios/specs/driver.rb

@@ -37,7 +37,7 @@ def sauce?
       actual[:caps][:app] = File.basename actual[:caps][:app]
       expected            = { caps:             { platformName: 'ios',
                                                   platformVersion: '10.1',
-                                                  automationName: 'xcuitest',
+                                                  automationName: 'XCUITest',
                                                   deviceName:   'iPhone Simulator',
                                                   app:          'UICatalog.app' },
                               custom_url:       false,
@@ -146,7 +146,11 @@ def sauce?
     end
 
     t 'driver' do
-      driver.browser.must_equal :iOS
+      driver.browser.must_be_empty
+    end
+
+    t 'automation_name_is_xcuitest?' do
+      automation_name_is_xcuitest?.must_equal UI::Inventory.xcuitest?
     end
 
     #
@@ -189,6 +193,7 @@ def sauce?
 
     # simple integration sanity test to check for unexpected exceptions
     t 'set_location' do
+      fail NotImplementedError, "XCUITest(Appium1.6.2) doesn't support yet" if UI::Inventory.xcuitest?
       set_location latitude: 55, longitude: -72, altitude: 33
     end
 
@@ -204,10 +209,13 @@ def sauce?
 
     # settings
     t 'get settings' do
+      fail NotImplementedError, "XCUITest(Appium1.6.2) doesn't support yet" if UI::Inventory.xcuitest?
       get_settings.wont_be_nil
     end
 
     t 'update settings' do
+      fail NotImplementedError, "XCUITest(Appium1.6.2) doesn't support yet" if UI::Inventory.xcuitest?
+
       update_settings cyberdelia: 'open'
       get_settings['cyberdelia'].must_equal 'open'
     end

ios_tests/lib/ios/specs/ios/element/alert.rb

@@ -3,18 +3,18 @@
   def nav_once
     screen.must_equal catalog
     wait_true do
-      text('alerts').click
+      UI::Inventory.xcuitest? ? find_element(:name, 'Alerts').click : text('alerts').click
       tag(UI::Inventory.navbar).name == 'Alerts' # wait for true
     end
 
-    tag(UI::Inventory.navbar).name.must_equal 'Alerts'
-
     # redefine method as no-op after it's invoked once
     self.class.send :define_method, :nav_once, proc {}
   end
 
   def after_last
-    alert_accept if exists { text('UIActionSheet <title>') }
+    alert_accept if exists do
+      UI::Inventory.xcuitest? ? find_elements(:name, 'UIActionSheet <title>') : text('UIActionSheet <title>')
+    end
     back_click
     screen.must_equal catalog
     sleep 1
@@ -27,9 +27,13 @@ def after_last
 
   def open_alert
     wait_true do
-      return true if exists { text('UIActionSheet <title>') }
-      text('Show OK-Cancel').click
-      text('UIActionSheet <title>').displayed?
+      if  UI::Inventory.xcuitest?
+        find_element(:name, 'Show OK-Cancel').click
+        find_element(:name, 'UIActionSheet <title>').displayed?
+      else
+        text('Show OK-Cancel').click
+        text('UIActionSheet <title>').displayed?
+      end
     end
   end
 

ios_tests/lib/ios/specs/ios/element/button.rb

@@ -3,7 +3,7 @@
   def before_first
     screen.must_equal catalog
     # nav to buttons activity
-    wait { text('buttons').click }
+    wait { UI::Inventory.xcuitest? ? find_element(:name, 'Buttons').click : text('buttons').click }
   end
 
   def after_last
@@ -21,14 +21,16 @@ def gray
 
   t 'button' do
     # by index
-    button(3).name.must_equal gray
+    button(3).name.must_equal gray # or UIButtonTypeInfoDark in XCUITest
 
     # by name contains
     button('ray').name.must_equal gray
   end
 
   t 'buttons' do
     exp = ['Back', 'Back', 'Gray', 'Right pointing arrow']
+    exp.concat ['Custom Text', 'More info', 'More info', 'More info', 'Add contact'] if UI::Inventory.xcuitest?
+
     target_buttons = buttons('a')
     target_buttons.map(&:name).must_equal exp
     target_buttons.length.must_equal exp.length
@@ -39,7 +41,8 @@ def gray
   end
 
   t 'last_button' do
-    last_button.name.must_equal 'Rounded'
+    expected = UI::Inventory.xcuitest? ? 'Add contact' : 'Rounded'
+    last_button.name.must_equal expected
   end
 
   t 'button_exact' do

ios_tests/lib/ios/specs/ios/element/text.rb

@@ -23,8 +23,10 @@ def before_first
   end
 
   t 'last_text' do
-    last_text.text.must_equal 'Shows UIViewAnimationTransitions'
-    last_text.name.must_equal 'Shows UIViewAnimationTransitions'
+    expected = UI::Inventory.xcuitest? ? 'Shows UIViewAnimationTransitions' : 'Transitions'
+
+    last_text.text.must_equal expected
+    last_text.name.must_equal expected
   end
 
   t 'text' do
@@ -35,7 +37,7 @@ def before_first
 
   t 'texts' do
     exp = ['Controls', 'Various uses of UIControl', 'Various uses of UISegmentedControl']
-    texts.length.must_equal 25
+    texts.length.must_equal(UI::Inventory.xcuitest? ? 25 : 24)
     texts('trol').map(&:name).must_equal exp
     texts('uses').length.must_equal 7
   end