"Got two different requests with the same idempotency key..." in POST commands

[KazuCocoa]

The problem

Below 'Got two different requests with the same idempotency key' appeared on POST command in current beta.

[debug] [HTTP] Request idempotency key: b5c06638-1f98-47fb-9a0e-58f1b53a6d67
[HTTP] Got two different requests with the same idempotency key 'b5c06638-1f98-47fb-9a0e-58f1b53a6d67'
[HTTP] Is the client generating idempotency keys properly?

https://gist.github.com/KazuCocoa/1073fc6727cf6577f998adf0c06d7994#file-gistfile1-txt-L538-L560

Environment

• Appium version (or git revision) that exhibits the issue: v1.18.0-beta.0
• Last Appium version that did not exhibit the issue (if applicable): 1.17.1
• Desktop OS/version used to run Appium: macOS 10.14
• Node.js version (unless using Appium.app|exe): 10.16
• Npm or Yarn package manager: 6.9.0
• Mobile platform/version under test: iOS/Android
• Real device or emulator/simulator: simulator/emulator
• Appium CLI or Appium.app|exe: cli

Details

I noticed the message when I ran POST command.
The attached example is on WebView, but I saw the message in timeout command like below in native context, so I wondered this happens POST command.

[debug] [HTTP] Request idempotency key: 4b6a8a2a-38f8-444b-b810-9c897e961291
[HTTP] Got two different requests with the same idempotency key '4b6a8a2a-38f8-444b-b810-9c897e961291'
[HTTP] Is the client generating idempotency keys properly?
[HTTP] --> POST /wd/hub/session/80f59ce0-f479-401e-b2f2-63e304a48be1/timeouts
[HTTP] {"implicit":0}
[debug] [W3C (80f59ce0)] Calling AppiumDriver.timeouts() with args: [null,null,null,null,0,"80f59ce0-f479-401e-b2f2-63e304a48be1"]
[debug] [XCUITest] Executing command 'timeouts'
[debug] [BaseDriver] W3C timeout argument: {"implicit":0}}
[debug] [BaseDriver] Set implicit wait to 0ms
[debug] [W3C (80f59ce0)] Responding to client with driver.timeouts() result: null
[HTTP] <-- POST /wd/hub/session/80f59ce0-f479-401e-b2f2-63e304a48be1/timeouts 200 6 ms - 14
[HTTP]
[debug] [HTTP] Request idempotency key: 4b6a8a2a-38f8-444b-b810-9c897e961291
[HTTP] Got two different requests with the same idempotency key '4b6a8a2a-38f8-444b-b810-9c897e961291'
[HTTP] Is the client generating idempotency keys properly?
[HTTP] --> POST /wd/hub/session/80f59ce0-f479-401e-b2f2-63e304a48be1/element
[HTTP] {"using":"name","value":"a"}
[debug] [W3C (80f59ce0)] Calling AppiumDriver.findElement() with args: ["name","a","80f59ce0-f479-401e-b2f2-63e304a48be1"]
[debug] [XCUITest] Executing command 'findElement'
[debug] [BaseDriver] Valid locator strategies for this request: xpath, id, name, class name, -ios predicate string, -ios class chain, accessibility id

Link to Appium logs

https://gist.github.com/KazuCocoa/1073fc6727cf6577f998adf0c06d7994

Code To Reproduce Issue [ Good To Have ]

e.g.

@driver.find_element :name, 'something'

[KazuCocoa]

ping @mykola-mokhnach
I haven't dug yet. I'll be able to dig in further tomorrow, probably, but it would be great if you had an idea :)

[mykola-mokhnach]

@KazuCocoa Which client it is? It looks like the client passes the same key to each request, which is wrong.

[KazuCocoa]

Ruby lib core, but that was my wrong, I noticed it a bit before. .. 😣
#259 (comment)

The header was remaining after a create session.

[KazuCocoa]

Moved to ruby lib core issue.
Will fix this soon