Final part of the binary targets implementation #2514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartbit
force-pushed
the
binary-targets-linking
branch
2 times, most recently
from
9e73749 to
7cfcb10
Compare
|
In addition to frameworks, XCFrameworks can also contain a dynamic/static library + headers. We should handle that case here as well. |
|
Thanks, I had forgotten about that case. |
hartbit
force-pushed
the
binary-targets-linking
branch
7 times, most recently
from
a3959cc to
92452a2
Compare
|
I now handle static and dynamic libraries. |
hartbit
force-pushed
the
binary-targets-linking
branch
from
92452a2 to
fbe9cba
Compare
aciidgh
reviewed
Jan 23, 2020
...argets/Framework.xcframework/macos-x86_64/Framework.framework/Versions/A/Headers/Framework.h
Outdated
Show resolved
Hide resolved
aciidgh
reviewed
Jan 23, 2020
...os-x86_64/Framework.framework/Versions/A/Modules/Framework.swiftmodule/x86_64.swiftinterface
Outdated
Show resolved
Hide resolved
aciidgh
reviewed
Jan 23, 2020
aciidgh
reviewed
Jan 23, 2020
aciidgh
reviewed
Jan 23, 2020
aciidgh
reviewed
Jan 23, 2020
|
Some minor comments but otherwise LGTM |
aciidgh
reviewed
Jan 24, 2020
aciidgh
approved these changes
Jan 24, 2020
hartbit
force-pushed
the
binary-targets-linking
branch
from
94985e5 to
996e557
Compare
|
@swift-ci smoke test |
hartbit
force-pushed
the
binary-targets-linking
branch
2 times, most recently
from
a1fa28e to
e015289
Compare
|
@swift-ci smoke test |
hartbit
force-pushed
the
binary-targets-linking
branch
from
e015289 to
d4a24f8
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process for linking against the XCFrameworks mimics how Xcode does it:
.frameworkin the build directory,-Foption to the compiler arguments pointing to the build directory,-Foption to the linker arguments pointing to the build directory.-frameworkoption to the linker arguments with the name of the framework.Based on #2511