Skip to content

Commit e71f9e9

Browse files
authored
Merge pull request #116 from arangodb/fix-prmr-init-container
Fixed expected value for ENGINE file in init container of dbserver.
2 parents 7cfeb00 + a884e03 commit e71f9e9

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

pkg/apis/deployment/v1alpha/storage_engine.go

+8
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@
2323
package v1alpha
2424

2525
import (
26+
"strings"
27+
2628
"github.com/pkg/errors"
2729
)
2830

@@ -47,6 +49,12 @@ func (se StorageEngine) Validate() error {
4749
}
4850
}
4951

52+
// AsArangoArgument returns the value for the given storage engine as it is to be used
53+
// for arangod's --server.storage-engine option.
54+
func (se StorageEngine) AsArangoArgument() string {
55+
return strings.ToLower(string(se))
56+
}
57+
5058
// NewStorageEngine returns a reference to a string with given value.
5159
func NewStorageEngine(input StorageEngine) *StorageEngine {
5260
return &input

pkg/deployment/resources/pod_creator.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ func createArangodArgs(apiObject metav1.Object, deplSpec api.DeploymentSpec, gro
9292

9393
// Storage engine
9494
options = append(options,
95-
optionPair{"--server.storage-engine", strings.ToLower(string(deplSpec.GetStorageEngine()))},
95+
optionPair{"--server.storage-engine", deplSpec.GetStorageEngine().AsArangoArgument()},
9696
)
9797

9898
// Logging
@@ -366,7 +366,7 @@ func (r *Resources) createPodForMember(spec api.DeploymentSpec, group api.Server
366366
SecretKey: constants.SecretKeyJWT,
367367
}
368368
}
369-
engine := string(spec.GetStorageEngine())
369+
engine := spec.GetStorageEngine().AsArangoArgument()
370370
requireUUID := group == api.ServerGroupDBServers && m.IsInitialized
371371
if err := k8sutil.CreateArangodPod(kubecli, spec.IsDevelopment(), apiObject, role, m.ID, m.PodName, m.PersistentVolumeClaimName, info.ImageID, spec.GetImagePullPolicy(),
372372
engine, requireUUID, args, env, livenessProbe, readinessProbe, tlsKeyfileSecretName, rocksdbEncryptionSecretName); err != nil {

0 commit comments

Comments
 (0)