Skip to content

Commit 07049e7

Browse files
authored
add zijianjoy (James Liu) as another org admin (kubeflow#443)
1 parent 6c63446 commit 07049e7

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

github-orgs/kubeflow/org.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ orgs:
1313
- theadactyl
1414
- k8s-ci-robot
1515
- google-oss-robot
16+
- zijianjoy
1617
billing_email: [email protected]
1718
company: ""
1819
default_repository_permission: read
@@ -311,7 +312,6 @@ orgs:
311312
- zhenghuiwang
312313
- zhujl1991
313314
- ziamsyed
314-
- zijianjoy
315315
- zjj2wry
316316
- JohanWork
317317
members_can_create_repositories: false

github-orgs/manifests/README.md

+9-7
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
# Auto sync for GitHub org
22

33
* **project**: kubeflow-admin
4-
* **cluster**: kf-admin-cluster
4+
* **cluster**: kf-admin-cluster
55
* **namespace**: github-admin
66

77
## Deploy new updates
88

99
Each change in this folder need to be deployed to take effect, only Kubeflow admins
1010
have the permission to do so. Follow these steps to connect to the admin cluster:
11-
```
11+
12+
```bash
1213
# First time
1314
gcloud container clusters get-credentials kf-admin-cluster --project kubeflow-admin --region us-central1-a
1415
# Rename the context to make future usage easier
@@ -18,7 +19,8 @@ kubectl config use-context kf-admin
1819
```
1920

2021
To update the deployments:
21-
```
22+
23+
```bash
2224
git checkout master
2325
git pull
2426
make apply
@@ -27,25 +29,25 @@ make apply
2729
## Trigger a github org sync manually
2830

2931
After connecting to `kf-admin` cluster like above:
30-
```
32+
33+
```bash
3134
make run-github-sync-once
3235
```
3336

3437
## Github Token
3538

3639
We need a GitHub token with admin:org priveleges
3740

38-
```
41+
```bash
3942
kubectl -n github-admin create secret generic github-org-admin-token-bobgy --from-file=github_token=<PATH TO TOKEN>
4043
```
4144

4245
* We are currently using the token **peribolos-kubeflow-org-admin** owned by Bobgy
4346

44-
4547
## Validate config map
4648

4749
We use a config map to provide the python code used to validate the config
4850

49-
```
51+
```bash
5052
make create-config-map
5153
```

github-orgs/manifests/validate_config.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def check_config(seld, config):
3131
# Check that each admin is in a whitelist set of admins.
3232
allowed_admins = ["Bobgy", "chensun", "google-admin", "googlebot",
3333
"google-oss-robot", "james-jwu", "jlewi", "k8s-ci-robot",
34-
"theadactyl"]
34+
"theadactyl", "zijianjoy"]
3535

3636
for a in admins:
3737
if not a in allowed_admins:

0 commit comments

Comments
 (0)