Skip to content

feat: add support for cloudflare images without custom domain #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 26, 2024

Conversation

dawaltconley
Copy link
Contributor

@dawaltconley dawaltconley commented May 23, 2024

Should fix #111

I wrote this pretty quick, fyi, as a patch for a project where I only need to support imagedelivery.net images.

Flagging the added filter here that removes empty transformation queries.

  const transformString = Object.entries(transformations)
    .filter(([key, value]) => Boolean(key) && value !== undefined)
    .map(([key, value]) => `${key}=${value}`)
    .join(",");

I added this because the current regex would pick up an image variant (e.g. /public) as a query and include it in the transform string (?public=undefined). But this change could potentially affect other cloudflare_image urls if I'm not understanding how their transformation queries work.

@dawaltconley dawaltconley changed the title add support for cloudflare images without custom domain feat: add support for cloudflare images without custom domain May 23, 2024
Copy link
Owner

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me, and the tests pass. It's blocked by a problem with the Supabase test site which I'll need to fix before merging

@grantborgognoni
Copy link

Any update on this? I'm having this issue inside unpic/svelte.

@ascorbic ascorbic merged commit 320784b into ascorbic:main Oct 26, 2024
4 checks passed
@mixie-bot mixie-bot bot mentioned this pull request Oct 26, 2024
ascorbic added a commit that referenced this pull request Oct 27, 2024
---------

Co-authored-by: dawaltconley <[email protected]>
Co-authored-by: Matt Kane <[email protected]>
@mixie-bot mixie-bot bot mentioned this pull request Dec 7, 2024
@mixie-bot mixie-bot bot mentioned this pull request Dec 15, 2024
ascorbic added a commit that referenced this pull request Jan 19, 2025
* wip

* wip

* wip more

* add contentstack

* wip lots more

* Cloudinary

* Update

* Add ipx

* format

* Remove test

* Change config syntax

* Add more

* Add scene7 and vercel

* chore: format

* Add shopify

* Simplify extractors

* chore: format

* Add uploadcare

* Add wordpress

* Add storyblok and cf images

* Rename

* Remove old

* chore: format

* Update

* Fix tests and build

* chore: format

* feat: add support for cloudflare images without custom domain (#131)

---------

Co-authored-by: dawaltconley <[email protected]>
Co-authored-by: Matt Kane <[email protected]>

* chore: add deprecation

* chore: format

* Add async

* fix: simplify types

* chore: format

* chore: lint

* fix: include detected cdn

* fix: strip unsupported props

* chore: tests and docs

* chore: remove duplicate definition

* chore: format

* chore: rename types

* chore: format

* chore: lint

* Change transformUrl syntax back to original

* Update README

* Add upgrading docs

* Add Hygraph support

* Update demo

* Fix

* Fix exports

* Fix cloudinary

* Add transformerfunction type

* ci: add pkg.pr.new (#153)

* ci: add pkg.pr.new

* Run on mine

* Fix path

* Include version

* Update Astro support for v5

* Only pass needed props

* Don't override options from URL with undefined ops

* Add names list

* As const

* Names

* Update contrib guide

---------

Co-authored-by: ascorbic <[email protected]>
Co-authored-by: dawaltconley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can you support cloudflare-image without custom domain?
3 participants