-
Notifications
You must be signed in to change notification settings - Fork 46
feat: add support for cloudflare images without custom domain #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascorbic
approved these changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good to me, and the tests pass. It's blocked by a problem with the Supabase test site which I'll need to fix before merging
Any update on this? I'm having this issue inside unpic/svelte. |
ascorbic
approved these changes
Oct 26, 2024
ascorbic
added a commit
that referenced
this pull request
Oct 27, 2024
--------- Co-authored-by: dawaltconley <[email protected]> Co-authored-by: Matt Kane <[email protected]>
ascorbic
added a commit
that referenced
this pull request
Jan 19, 2025
* wip * wip * wip more * add contentstack * wip lots more * Cloudinary * Update * Add ipx * format * Remove test * Change config syntax * Add more * Add scene7 and vercel * chore: format * Add shopify * Simplify extractors * chore: format * Add uploadcare * Add wordpress * Add storyblok and cf images * Rename * Remove old * chore: format * Update * Fix tests and build * chore: format * feat: add support for cloudflare images without custom domain (#131) --------- Co-authored-by: dawaltconley <[email protected]> Co-authored-by: Matt Kane <[email protected]> * chore: add deprecation * chore: format * Add async * fix: simplify types * chore: format * chore: lint * fix: include detected cdn * fix: strip unsupported props * chore: tests and docs * chore: remove duplicate definition * chore: format * chore: rename types * chore: format * chore: lint * Change transformUrl syntax back to original * Update README * Add upgrading docs * Add Hygraph support * Update demo * Fix * Fix exports * Fix cloudinary * Add transformerfunction type * ci: add pkg.pr.new (#153) * ci: add pkg.pr.new * Run on mine * Fix path * Include version * Update Astro support for v5 * Only pass needed props * Don't override options from URL with undefined ops * Add names list * As const * Names * Update contrib guide --------- Co-authored-by: ascorbic <[email protected]> Co-authored-by: dawaltconley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #111
I wrote this pretty quick, fyi, as a patch for a project where I only need to support
imagedelivery.net
images.Flagging the added filter here that removes empty transformation queries.
I added this because the current regex would pick up an image variant (e.g.
/public
) as a query and include it in the transform string (?public=undefined
). But this change could potentially affect other cloudflare_image urls if I'm not understanding how their transformation queries work.