fix crate_name #56
Merged
fix crate_name #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleygwilliams
force-pushed
the
crate-name-fix
branch
from
791623a to
d6a985a
Compare
fitzgen
approved these changes
Jul 26, 2018
tests/integration/basics.rs
Outdated
|
|
||
| assert!( | ||
| dir.read("foobar-project/main.rs") | ||
| .contains("foobar_project") |
There was a problem hiding this comment.
maybe assert that it also doesn't contain "foobar-project"?
There was a problem hiding this comment.
oh good call
There was a problem hiding this comment.
(i did that manually, so i don't know why i didn't think to add it. thank u!)
ashleygwilliams
force-pushed
the
crate-name-fix
branch
from
d6a985a to
1ccbf57
Compare
ashleygwilliams
force-pushed
the
crate-name-fix
branch
from
1ccbf57 to
d4cec7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #41 and #34