Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialize response context as a response header #5928

Closed
SergeyKanzhelev opened this issue Jun 12, 2018 · 6 comments
Closed

Serialize response context as a response header #5928

SergeyKanzhelev opened this issue Jun 12, 2018 · 6 comments
Labels
accepted This issue has completed "acceptance" testing (including accessibility) area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one
Milestone
3.0.0-preview6

Comments

@SergeyKanzhelev
Copy link

Motivation

In distributed tracing scenarios it is not uncommon to return extra context as a response headers when possible. DiagnosticsSource Acitvity should implement API that will allow to set the response context. Fields populated by this API should be serialized as http response headers.

CC: @seth-capistron, @vancem, @jacpull, @lmolkova, @glennc, @davidfowl
@aspnet-hello aspnet-hello transferred this issue from aspnet/Hosting Dec 18, 2018
@aspnet-hello aspnet-hello added this to the 3.0.0 milestone Dec 18, 2018
@aspnet-hello aspnet-hello added area-hosting enhancement This issue represents an ask for new feature or an enhancement to an existing one labels Dec 18, 2018
@muratg
Copy link
Contributor

muratg commented Jan 9, 2019

cc @shirhatti @davidfowl @Tratcher

@analogrelay
Copy link
Contributor

To clarify, this is blocked on getting https://github.com/dotnet/corefx/issues/30335 in, right?

@lmolkova are these APIs going in to corefx? (cc @glennc)

@analogrelay analogrelay modified the milestones: 3.0.0, 3.0.0-preview6 Mar 29, 2019
@lmolkova
Copy link

@anurse no, at this point there is no work in corefx to support response context. @SergeyKanzhelev do we still need this?

@analogrelay
Copy link
Contributor

Epic #8924

@analogrelay analogrelay mentioned this issue Mar 29, 2019
Closed
3 tasks
@analogrelay
Copy link
Contributor

Closing as there isn't a W3C spec here yet. @SergeyKanzhelev is working on that and we can re-open when that happens.

@SergeyKanzhelev
Copy link
Author

Let's re-open when W3C has a spec for response headers

@analogrelay analogrelay added the accepted This issue has completed "acceptance" testing (including accessibility) label May 3, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2019
@amcasey amcasey added the area-hosting Includes Hosting label Jun 1, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted This issue has completed "acceptance" testing (including accessibility) area-hosting Includes Hosting area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions enhancement This issue represents an ask for new feature or an enhancement to an existing one
Projects
None yet
Milestone
3.0.0-preview6
Development

No branches or pull requests
7 participants
@analogrelay @muratg @JunTaoLuo @lmolkova @SergeyKanzhelev @amcasey @aspnet-hello