Add-pubkey modal, refactor register comps #238

joepio · joepio · commit a30d3e2ef5a0 · 2023-02-19T14:15:13.000+01:00
diff --git a/data-browser/src/components/Dialog/useDialog.tsx b/data-browser/src/components/Dialog/useDialog.tsx
@@ -23,7 +23,6 @@ export const useDialog = (): UseDialogReturnType => {
   }, []);
 
   const close = useCallback(() => {
-    console.log('close', close);
     setShowDialog(false);
   }, []);
 
diff --git a/data-browser/src/components/RegisterSignIn.tsx b/data-browser/src/components/RegisterSignIn.tsx
@@ -8,7 +8,13 @@ import {
 import React, { FormEvent, useCallback, useEffect, useState } from 'react';
 import { useSettings } from '../helpers/AppSettings';
 import { Button } from './Button';
-import { nameRegex, register, useServerURL, useStore } from '@tomic/react';
+import {
+  addPublicKey,
+  nameRegex,
+  register as createRegistration,
+  useServerURL,
+  useStore,
+} from '@tomic/react';
 import Field from './forms/Field';
 import { InputWrapper, InputStyled } from './forms/InputStyles';
 import { Row } from './Row';
@@ -20,6 +26,16 @@ interface RegisterSignInProps {
   redirect?: string;
 }
 
+/** What is currently showing */
+enum PageStateOpts {
+  none,
+  signIn,
+  register,
+  reset,
+  mailSentRegistration,
+  mailSentAddPubkey,
+}
+
 /**
  * Two buttons: Register / Sign in.
  * Opens a Dialog / Modal with the appropriate form.
@@ -29,7 +45,8 @@ export function RegisterSignIn({
 }: React.PropsWithChildren<RegisterSignInProps>): JSX.Element {
   const { dialogProps, show, close } = useDialog();
   const { agent } = useSettings();
-  const [isRegistering, setRegister] = useState(true);
+  const [pageState, setPageState] = useState<PageStateOpts>(PageStateOpts.none);
+  const [email, setEmail] = useState('');
 
   if (agent) {
     return <>{children}</>;
@@ -39,7 +56,7 @@ export function RegisterSignIn({
         <Row>
           <Button
             onClick={() => {
-              setRegister(true);
+              setPageState(PageStateOpts.register);
               show();
             }}
           >
@@ -48,27 +65,116 @@ export function RegisterSignIn({
           <Button
             subtle
             onClick={() => {
-              setRegister(false);
+              setPageState(PageStateOpts.signIn);
               show();
             }}
           >
             Sign In
           </Button>
         </Row>
         <Dialog {...dialogProps}>
-          {isRegistering ? <Register close={close} /> : <SignIn />}
+          {pageState === PageStateOpts.register && (
+            <Register
+              setPageState={setPageState}
+              email={email}
+              setEmail={setEmail}
+            />
+          )}
+          {pageState === PageStateOpts.signIn && (
+            <SignIn setPageState={setPageState} />
+          )}
+          {pageState === PageStateOpts.reset && (
+            <Reset
+              email={email}
+              setEmail={setEmail}
+              setPageState={setPageState}
+            />
+          )}
+          {pageState === PageStateOpts.mailSentRegistration && (
+            <MailSentConfirm
+              email={email}
+              close={close}
+              message={'Your account will be created when you open that link.'}
+            />
+          )}
+          {pageState === PageStateOpts.mailSentAddPubkey && (
+            <MailSentConfirm
+              email={email}
+              close={close}
+              message={'Click that link to create a new PassPhrase.'}
+            />
+          )}
         </Dialog>
       </>
     );
 }
 
-function Register({ close }) {
+function Reset({ email, setEmail, setPageState }) {
+  const store = useStore();
+  const [err, setErr] = useState<Error | undefined>(undefined);
+
+  const handleRequestReset = useCallback(async () => {
+    try {
+      await addPublicKey(store, email);
+      setPageState(PageStateOpts.mailSentAddPubkey);
+    } catch (e) {
+      setErr(e);
+    }
+  }, [email]);
+
+  return (
+    <>
+      <DialogTitle>
+        <h1>Reset your PassKey</h1>
+      </DialogTitle>
+      <DialogContent>
+        <p>
+          {
+            "Lost it? No worries, we'll send a link that let's you create a new one."
+          }
+        </p>
+        <EmailField
+          email={email}
+          setEmail={(e: any) => {
+            setErr(undefined);
+            setEmail(e);
+          }}
+        />
+        {err && <ErrorLook>{err.message}</ErrorLook>}
+      </DialogContent>
+      <DialogActions>
+        <Button onClick={handleRequestReset}>Send me</Button>
+      </DialogActions>
+    </>
+  );
+}
+
+function MailSentConfirm({ email, close, message }) {
+  return (
+    <>
+      <DialogTitle>
+        <h1>Go to your email inbox</h1>
+      </DialogTitle>
+      <DialogContent>
+        <p>
+          {"We've sent a confirmation link to "}
+          <strong>{email}</strong>
+          {'.'}
+        </p>
+        <p>{message}</p>
+      </DialogContent>
+      <DialogActions>
+        <Button onClick={close}>{"Ok, I'll open my mailbox!"}</Button>
+      </DialogActions>
+    </>
+  );
+}
+
+function Register({ setPageState, email, setEmail }) {
   const [name, setName] = useState('');
-  const [email, setEmail] = useState('');
   const [serverUrlStr] = useServerURL();
   const [nameErr, setErr] = useState<Error | undefined>(undefined);
   const store = useStore();
-  const [mailSent, setMailSent] = useState(false);
 
   const serverUrl = new URL(serverUrlStr);
   serverUrl.host = `${name}.${serverUrl.host}`;
@@ -93,36 +199,15 @@ function Register({ close }) {
       }
 
       try {
-        await register(store, name, email);
-        setMailSent(true);
+        await createRegistration(store, name, email);
+        setPageState(PageStateOpts.mailSentRegistration);
       } catch (er) {
         setErr(er);
       }
     },
     [name, email],
   );
 
-  if (mailSent) {
-    return (
-      <>
-        <DialogTitle>
-          <h1>Go to your email inbox</h1>
-        </DialogTitle>
-        <DialogContent>
-          <p>
-            {"We've sent a confirmation link to "}
-            <strong>{email}</strong>
-            {'.'}
-          </p>
-          <p>Your account will be created when you open that link.</p>
-        </DialogContent>
-        <DialogActions>
-          <Button onClick={close}>Ok, I will!</Button>
-        </DialogActions>
-      </>
-    );
-  }
-
   return (
     <>
       <DialogTitle>
@@ -147,48 +232,63 @@ function Register({ close }) {
               />
             </InputWrapper>
           </Field>
-          <Field label='E-mail'>
-            <InputWrapper>
-              <InputStyled
-                autoFocus={true}
-                type={'email'}
-                required
-                value={email}
-                onChange={e => {
-                  setEmail(e.target.value);
-                }}
-              />
-            </InputWrapper>
-          </Field>
+          <EmailField email={email} setEmail={setEmail} />
           {name && nameErr && <ErrorLook>{nameErr.message}</ErrorLook>}
         </form>
       </DialogContent>
       <DialogActions>
+        <Button subtle onClick={() => setPageState(PageStateOpts.signIn)}>
+          Sign in
+        </Button>
         <Button
           type='submit'
           form='register-form'
           disabled={!name || !!nameErr}
           onClick={handleSubmit}
         >
-          Create
+          Save
         </Button>
       </DialogActions>
     </>
   );
 }
 
-function SignIn() {
+function SignIn({ setPageState }) {
   return (
     <>
       <DialogTitle>
-        <h1>Sign in </h1>
+        <h1>Sign in</h1>
       </DialogTitle>
       <DialogContent>
         <SettingsAgent />
       </DialogContent>
       <DialogActions>
-        <p>Lost your passphrase?</p>
+        <Button subtle onClick={() => setPageState(PageStateOpts.register)}>
+          Register
+        </Button>
+        <Button subtle onClick={() => setPageState(PageStateOpts.reset)}>
+          I lost my passphrase
+        </Button>
       </DialogActions>
     </>
   );
 }
+
+function EmailField({ setEmail, email }) {
+  return (
+    <Field label='E-mail'>
+      <InputWrapper>
+        <InputStyled
+          // This is not properly working atm
+          autoFocus
+          type={'email'}
+          required
+          value={email}
+          onChange={e => {
+            setEmail(e.target.value);
+          }}
+        />
+      </InputWrapper>
+    </Field>
+  );
+}
diff --git a/data-browser/src/views/ErrorPage.tsx b/data-browser/src/views/ErrorPage.tsx
@@ -33,6 +33,11 @@ function ErrorPage({ resource }: ResourcePageProps): JSX.Element {
           <h1>Unauthorized</h1>
           {agent ? (
             <>
+              <p>
+                {
+                  "You don't have access to this. Try asking for access, or sign in with a different account."
+                }
+              </p>
               <ErrorBlock error={resource.error!} />
               <span>
                 <Button onClick={() => store.fetchResourceFromServer(subject)}>
diff --git a/lib/src/authentication.ts b/lib/src/authentication.ts
@@ -141,7 +141,34 @@ export async function register(
   const description = resource.get(properties.description) as string;
 
   if (!description.includes('success')) {
-    throw new Error('ERRORORRRR');
+    throw new Error('Expected a `success` message, did not receive one');
+  }
+
+  return;
+}
+
+/** Asks the server to add a public key to an account. Will lead to a confirmation link being sent */
+export async function addPublicKey(store: Store, email: string): Promise<void> {
+  if (!email) {
+    throw new Error('No email provided');
+  }
+
+  const url = new URL('/add-public-key', store.getServerUrl());
+  url.searchParams.set('email', email);
+  const resource = await store.getResourceAsync(url.toString());
+
+  if (!resource) {
+    throw new Error('No resource received');
+  }
+
+  if (resource.error) {
+    throw resource.error;
+  }
+
+  const description = resource.get(properties.description) as string;
+
+  if (!description.includes('success')) {
+    throw new Error('Expected a `success` message, did not receive one');
   }
 
   return;
@@ -169,13 +196,21 @@ export async function confirmEmail(
 
   let agent = store.getAgent();
 
+  // No agent, create a new one
   if (!agent) {
     const keypair = await generateKeyPair();
     const newAgent = new Agent(keypair.privateKey);
     newAgent.subject = `${store.getServerUrl()}/agents/${parsed.name}`;
     agent = newAgent;
   }
 
+  // An agent already exists, make sure it matches the confirm email token
+  if (!agent?.subject?.includes(parsed.name)) {
+    throw new Error(
+      'You cannot confirm this email, you are already logged in as a different user',
+    );
+  }
+
   url.searchParams.set('public-key', await agent.getPublicKey());
   const resource = await store.getResourceAsync(url.toString());
 
