inScope:JSObjectionScopeSingleton doesn't work since Cocoapods version 1.6

[pual]

I'm using the singleton registration ([self bindClass:... inScope:JSObjectionScopeSingleton];) in a JSObjectionModule in my app for quite a while.
After a pod update to version 1.6 the singleton scope is ignored and handled like JSObjectionScopeNormal.

[mpurland]

+1

[jdewind]

Odd,

I'll look into it today.

[jdewind]

I'm unable to reproduce the issue and I do have a test that exercises the "inScope" registration.

See https://github.com/atomicobject/objection/blob/develop/Specs/ModuleUsageSpecs.m#L172.

I'll need to have a code example to investigate further at this point. Also, its important that there aren't multiple revisions of Objection running within the project -- that can cause these kind of strange issues.

[zintus]

My quick investigation shown, that problem lies in absence of synthesize statement for lifeCycle property in JSObjectionProviderEntry.m file. This leads to usage of property getter defined in base class (JSObjectionEntry.m), always returning JSObjectionScopeNone.

[jdewind]

Good catch. I'm disappointed that the tests are unable to reproduce it.

[zintus]

I'm happy to help!

[plu]

I'd help too, but I'm not sure what's the current state of the repo. If I try to run the test suites on Xcode 6.4, it doesn't even build. When I update Quick and Nimble submodules to latest master, it works. But then some tests are failing.

[jdewind]

@plu Its running in travis and all tests are passing. I believe it is using the same version of XCode as well.

[plu]

@dewind I don't think so. It's using Xcode 6.1:

https://travis-ci.org/atomicobject/objection/builds/73209281

Xcode 6.1
Build version 6A1052c

You need to click on announce right next to $ xcodebuild -version -sdk to see the full output.

It's definitely broken on 6.4. What's your local setup? :)

But of course I just might be missing something here :)

[jdewind]

@plu Similar to Travis CI. I'll need to get on a machine with 6.4 and address those issues ASAP. I'll open a new issue.

[plu]

Cool thanks! I can have a look at them too right now.

[plu]

What about cutting a new release 1.7? :)

[scottkilker]

Any updates on this issue?

[zintus]

Up

[jdewind]

Sorry guys,

I'll review the issue this week.

[zintus]

@dewind gentle bump :)

[CapnSpellcheck]

This made it into 1.6.1 did it not? https://github.com/atomicobject/objection/releases/tag/1.6.1

[zintus]

Oh, I'm sorry 😬

Let's close issue then?

[pual]

Yes, it works now, thanks!