Skip to content

Commit 49b2bb5

Browse files
authored
Merge pull request #491 from atomistic-machine-learning/sh/lightning_update
fix: LightningLoggerBase was removed in lightning 1.9
2 parents 2ac4ef2 + 5ec8ed9 commit 49b2bb5

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ PyYAML
22
--index-url https://pypi.python.org/simple/
33

44
torch>=1.9
5-
pytorch_lightning>=1.8.1
5+
pytorch_lightning>=1.9.0
66
protobuf==3.20.2
77
hydra-core>=1.1.0
88
hydra-colorlog>=1.1.0

setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def read(fname):
3030
"h5py",
3131
"pyyaml",
3232
"hydra-core>=1.1.0",
33-
"pytorch_lightning>=1.8.1",
33+
"pytorch_lightning>=1.9.0",
3434
"torchmetrics",
3535
"hydra-colorlog>=1.1.0",
3636
"rich",

src/schnetpack/cli.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from omegaconf import DictConfig, OmegaConf
1111
from pytorch_lightning import LightningModule, LightningDataModule, Callback, Trainer
1212
from pytorch_lightning import seed_everything
13-
from pytorch_lightning.loggers import LightningLoggerBase
13+
from pytorch_lightning.loggers.logger import Logger
1414

1515
import schnetpack as spk
1616
from schnetpack.utils import str2class
@@ -129,7 +129,7 @@ def train(config: DictConfig):
129129
callbacks.append(hydra.utils.instantiate(cb_conf))
130130

131131
# Init Lightning loggers
132-
logger: List[LightningLoggerBase] = []
132+
logger: List[Logger] = []
133133

134134
if "logger" in config:
135135
for _, lg_conf in config["logger"].items():

0 commit comments

Comments
 (0)