Skip to content

Commit 4b6323e

Browse files
committed
Use Map/Set instead of Object.create(null)
1 parent 9c8d7a2 commit 4b6323e

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

lib/ava-files.js

+6-6
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ function handlePaths(files, excludePatterns, globOptions) {
1313
// Convert Promise to Bluebird
1414
files = Promise.resolve(globby(files.concat(excludePatterns), globOptions));
1515

16-
const searchedParents = Object.create(null);
17-
const foundFiles = Object.create(null);
16+
const searchedParents = new Set();
17+
const foundFiles = new Set();
1818

1919
function alreadySearchingParent(dir) {
20-
if (searchedParents[dir]) {
20+
if (searchedParents.has(dir)) {
2121
return true;
2222
}
2323

@@ -40,7 +40,7 @@ function handlePaths(files, excludePatterns, globOptions) {
4040
return null;
4141
}
4242

43-
searchedParents[file] = true;
43+
searchedParents.add(file);
4444

4545
let pattern = path.join(file, '**', '*.js');
4646

@@ -67,8 +67,8 @@ function handlePaths(files, excludePatterns, globOptions) {
6767
})
6868
.map(file => path.resolve(file))
6969
.filter(file => {
70-
const alreadyFound = foundFiles[file];
71-
foundFiles[file] = true;
70+
const alreadyFound = foundFiles.has(file);
71+
foundFiles.add(file);
7272
return !alreadyFound;
7373
});
7474
}

lib/process-adapter.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -62,18 +62,18 @@ if (debug.enabled) {
6262
require('time-require'); // eslint-disable-line import/no-unassigned-import
6363
}
6464

65-
const sourceMapCache = Object.create(null);
65+
const sourceMapCache = new Map();
6666
const cacheDir = opts.cacheDir;
6767

6868
exports.installSourceMapSupport = () => {
6969
sourceMapSupport.install({
7070
environment: 'node',
7171
handleUncaughtExceptions: false,
7272
retrieveSourceMap(source) {
73-
if (sourceMapCache[source]) {
73+
if (sourceMapCache.has(source)) {
7474
return {
7575
url: source,
76-
map: fs.readFileSync(sourceMapCache[source], 'utf8')
76+
map: fs.readFileSync(sourceMapCache.get(source), 'utf8')
7777
};
7878
}
7979
}
@@ -85,7 +85,7 @@ exports.installPrecompilerHook = () => {
8585
const precompiled = opts.precompiled[filename];
8686

8787
if (precompiled) {
88-
sourceMapCache[filename] = path.join(cacheDir, precompiled + '.js.map');
88+
sourceMapCache.set(filename, path.join(cacheDir, precompiled + '.js.map'));
8989
return fs.readFileSync(path.join(cacheDir, precompiled + '.js'), 'utf8');
9090
}
9191

0 commit comments

Comments
 (0)