Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving files patterns from API constructor to run() method #534

Closed
novemberborn opened this issue Feb 9, 2016 · 2 comments
Closed
Labels
enhancement new functionality

Comments

@novemberborn
Copy link
Member

#502 allows files patterns to be provided to API#run(). This will override the patterns provided in the API constructor.

For simplicity we could consider removing the files argument from the constructor and requiring it in run(). This will break the programmatic API.

Currently the watcher provides the files argument to API#run(). If provided the test titles will always be prefixed, even if only a single test is run. This behavior makes sense for the watcher but is different from normal usage. We should maintain this behavior.

@vadimdemedes
Copy link
Contributor

I think this is a good suggestion and we should do it.

@sotojuan
Copy link
Contributor

sotojuan commented Feb 9, 2016

Also agree that this is good and currently working on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants