Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test-like output when test file does not exist #575

Closed
vadimdemedes opened this issue Feb 28, 2016 · 6 comments
Closed

Test-like output when test file does not exist #575

vadimdemedes opened this issue Feb 28, 2016 · 6 comments
Labels
bug current functionality does not work as desired good for beginner help wanted

Comments

@vadimdemedes
Copy link
Contributor

The output is not what it should look like (latest master):

$ ava example.js

(example.js does not exist).

screen shot 2016-02-28 at 1 46 21 pm

First of all, notice 1 extra line at the start & end of the output. And top-level CLI errors should be displayed as:


  ❎ Couldn't find any files to test

@vadimdemedes vadimdemedes added bug current functionality does not work as desired help wanted good for beginner labels Feb 28, 2016
@novemberborn
Copy link
Member

This is probably due to https://github.com/novemberborn/ava/commit/9dd03d5d2b20de48e72cb59e29573dd412201b1b (see #502). There's some variance between the reporters, looks like the verbose one should render a cross.

Maybe this particular exception should be treated differently in the mini reporter. Or perhaps a general case can be made when there is 1 exception and no tests where found.

@vadimdemedes
Copy link
Contributor Author

No no, this kind of top-level output from CLI should be written without reporters, as those are fatal errors.

@novemberborn
Copy link
Member

No no, this kind of top-level output from CLI should be written without reporters, as those are fatal errors.

Not when watching though. It's legit to start a watcher even if there are no test files yet. Or to remove the only test file while the watcher is running.

@sotojuan
Copy link
Contributor

What's the status of this? A simple edit to reporters/mini.js fixes the extra lines, but what about the cross? Also an easy fix in the reporter file.

@novemberborn
Copy link
Member

If we can agree that these are not fatal errors then I think we can fix up the reporters.

@sotojuan
Copy link
Contributor

Closing because this was fixed a while back in #704.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug current functionality does not work as desired good for beginner help wanted
Projects
None yet
Development

No branches or pull requests

3 participants