Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to abort test run #710

Closed
sindresorhus opened this issue Apr 4, 2016 · 6 comments
Closed

Ability to abort test run #710

sindresorhus opened this issue Apr 4, 2016 · 6 comments

Comments

@sindresorhus
Copy link
Member

Would be useful to have a way to abort the current test run. CLI users can just Cmd+C, but from the API there's currently no way to cancel the test run.

I vaguely remember us talking about something like this being useful for watch mode.
(@novemberborn ?)

An easy solution would be to just have the runner kill the forked processes.

From avajs/atom-ava#8 (comment).

@novemberborn
Copy link
Member

I vaguely remember us talking about something like this being useful for watch mode.

Yes, #518. Fair amount of discussion in that issue.

With #78 we'll no longer be running all test files at the same time, so aborting the test run could let current test files run to completion without starting new ones.

@jamestalmage
Copy link
Contributor

I want to take this on. #713 is a refactor in preparation for this. I'd appreciate a quick review on that

@sindresorhus
Copy link
Member Author

@jamestalmage Assigned.

(Sidenote: We should use the "assignment" feature more)

@jamestalmage
Copy link
Contributor

I would have, but on mobile

@sindresorhus
Copy link
Member Author

The mobile version is completely useless. It misses so many features I don't even bother to use it anymore. Better to use the desktop version on mobile and zoom in and out.

@novemberborn
Copy link
Member

@jamestalmage from #518 I think we should:

  • not start any serial tests that haven't yet been started
  • disconnect the reporters from the current run
  • as much as possible let the forks run to completion
  • but maybe kill the processes to avoid blocking the (upcoming) process pool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants