Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename errors.Annotate to errors.Wrap #15

Closed
avamsi opened this issue Nov 24, 2024 · 2 comments
Closed

Rename errors.Annotate to errors.Wrap #15

avamsi opened this issue Nov 24, 2024 · 2 comments

Comments

@avamsi
Copy link
Owner

avamsi commented Nov 24, 2024

Don't remember why I named it Annotate in the first place (I think I considered Wrap?)
@avamsi
Copy link
Owner Author

avamsi commented Dec 2, 2024

See the name Handle in golang/go#32437 too (and how they avoid multiple format calls with *err = fmt.Errorf(format + ": %v", append(args, *err)...) -- how is this better?).

@avamsi
Copy link
Owner Author

avamsi commented Dec 18, 2024

Fixed in 7faf2ef.

@avamsi avamsi closed this as completed Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@avamsi