Skip to content

Commit 3f347fa

Browse files
committed
Removing unnecessary typeof operators
1 parent fb27fd3 commit 3f347fa

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

lib/filesize.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* @license BSD-3 <http://opensource.org/licenses/BSD-3-Clause>
77
* @link http://filesizejs.com
88
* @module filesize
9-
* @version 1.7.4
9+
* @version 1.7.5
1010
*/
1111

1212
(function (global) {
@@ -24,16 +24,16 @@
2424
var base = 10,
2525
bit, byte, i, neg, num, pos, regex, result, short, size, sizes, suffix, z, zero;
2626

27-
if (typeof arguments[2] !== "undefined") {
27+
if (arguments[2] !== undefined) {
2828
pos = arguments[1];
2929
short = arguments[2];
3030
}
3131
else typeof arguments[1] === "boolean" ? short = arguments[1] : pos = arguments[1];
3232

33-
if (isNaN(arg) || (typeof pos !== "undefined" && isNaN(pos))) throw Error("Invalid arguments");
33+
if (isNaN(arg) || (pos !== undefined && isNaN(pos))) throw Error("Invalid arguments");
3434

3535
short = (short === true);
36-
pos = short ? 1 : (typeof pos === "undefined" ? 2 : parseInt(pos, base));
36+
pos = short ? 1 : (pos === undefined ? 2 : parseInt(pos, base));
3737
num = Number(arg);
3838
neg = (num < 0);
3939
sizes = [["B", 0], ["Kb", 128], ["KB", 1024], ["Mb", 131072], ["MB", "1.049e+6"], ["Gb", "1.342e+8"], ["GB", "1.074e+9"], ["Tb", "1.374e+11"], ["TB", "1.1e+12"], ["Pb", "1.407e+14"], ["PB", "1.126e+15"]];
@@ -57,7 +57,7 @@
5757
if (bit.test(suffix)) suffix = suffix.toLowerCase();
5858
suffix = suffix.slice(0, 1);
5959
z = regex.exec(result);
60-
if (z !== null && typeof z[1] !== "undefined" && zero.test(z[1])) result = parseInt(result, base);
60+
if (z !== null && z[1] !== undefined && zero.test(z[1])) result = parseInt(result, base);
6161
}
6262
result += suffix;
6363
break;

lib/filesize.min.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "filesize",
33
"description": "JavaScript library to generate a human readable String describing the file size",
4-
"version": "1.7.4",
4+
"version": "1.7.5",
55
"homepage": "http://filesizejs.com",
66
"author": {
77
"name": "Jason Mulligan",

src/filesize.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,16 @@
1313
var base = 10,
1414
bit, byte, i, neg, num, pos, regex, result, short, size, sizes, suffix, z, zero;
1515

16-
if (typeof arguments[2] !== "undefined") {
16+
if (arguments[2] !== undefined) {
1717
pos = arguments[1];
1818
short = arguments[2];
1919
}
2020
else typeof arguments[1] === "boolean" ? short = arguments[1] : pos = arguments[1];
2121

22-
if (isNaN(arg) || (typeof pos !== "undefined" && isNaN(pos))) throw Error("Invalid arguments");
22+
if (isNaN(arg) || (pos !== undefined && isNaN(pos))) throw Error("Invalid arguments");
2323

2424
short = (short === true);
25-
pos = short ? 1 : (typeof pos === "undefined" ? 2 : parseInt(pos, base));
25+
pos = short ? 1 : (pos === undefined ? 2 : parseInt(pos, base));
2626
num = Number(arg);
2727
neg = (num < 0);
2828
sizes = [["B", 0], ["Kb", 128], ["KB", 1024], ["Mb", 131072], ["MB", "1.049e+6"], ["Gb", "1.342e+8"], ["GB", "1.074e+9"], ["Tb", "1.374e+11"], ["TB", "1.1e+12"], ["Pb", "1.407e+14"], ["PB", "1.126e+15"]];
@@ -46,7 +46,7 @@
4646
if (bit.test(suffix)) suffix = suffix.toLowerCase();
4747
suffix = suffix.slice(0, 1);
4848
z = regex.exec(result);
49-
if (z !== null && typeof z[1] !== "undefined" && zero.test(z[1])) result = parseInt(result, base);
49+
if (z !== null && z[1] !== undefined && zero.test(z[1])) result = parseInt(result, base);
5050
}
5151
result += suffix;
5252
break;

0 commit comments

Comments
 (0)