Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with Node.js v12? #168

Closed
medikoo opened this issue Dec 12, 2022 · 3 comments
Closed

Not compatible with Node.js v12? #168

medikoo opened this issue Dec 12, 2022 · 3 comments

Comments

@medikoo
Copy link

medikoo commented Dec 12, 2022

Recently following the CHANGELOG, I've upgraded filesize from v8 to v10.

There are no notes in CHANGELOG that support for Node.js v12 was dropped. Yet suddenly, I got a report from a user stating that you log a warning that Node.js v12 is not supported. Is that the case?

If it's the case, can you indicate that in the CHANGELOG file to avoid further confusion (?) Otherwise, can you update the warning notice so it doesn't scream at Node.js v12 users

@avoidwork
Copy link
Owner

The lib doesn't emit such a message, but I can lower the engine to 10.0.0 because it has bigint support.

The changelog is generated, it's hard to guess what would matter to a person in the future when considering my writing style.

@medikoo
Copy link
Author

medikoo commented Dec 12, 2022

@avoidwork npm emits that message based on metadata in package.json. Also, you've already fixed that once: #161 :)

@avoidwork
Copy link
Owner

@medikoo this is fixed with 10.0.6, such that 10.4.0 is the minimum version.

Regarding min version... I moved it from 0.4.0 to current stable after 11 years, it's interesting to see what products are using what versions due to RTE, etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants