Skip to content
This repository was archived by the owner on Sep 2, 2018. It is now read-only.

Make AVR triple valid #35

Closed
dylanmckay opened this issue Feb 17, 2015 · 10 comments
Closed

Make AVR triple valid #35

dylanmckay opened this issue Feb 17, 2015 · 10 comments

Comments

@dylanmckay
Copy link
Member

Currently, the target triple for AVR is avr-none.

This is not a valid triple (see here).

I believe it should be avr-unknown-none or avr-atmel-none.

@dylanmckay
Copy link
Member Author

Check what AVR-GCC uses.

@RandomInsano
Copy link

Well, by the docs, it should be avr-atmel-none right?

@dylanmckay
Copy link
Member Author

I thought so, but look at the output of avr-gcc -v:

Using built-in specs.
...
Target: avr
..
gcc version 4.9.2 20141224 (prerelease) (GCC) 

versus gcc -v on my machine:

Using built-in specs.
..
Target: x86_64-unknown-linux-gnu
...
gcc version 4.9.2 20141224 (prerelease) (GCC) 

"Target" is the target triple. For x64, it is in the normal triple format. For avr, it is not.

@dylanmckay
Copy link
Member Author

See this page as well.

@RandomInsano
Copy link

Weird. I guess ask the LLVM mailing list? The elders there may have an idea as to why GCC chose that route? It can't possibly be a flame/war bike shed topic right?

@dylanmckay
Copy link
Member Author

The AVR-GCC mailing list might be a better option.

It can't possibly be a flame/war bike shed topic right?

I doubt it, but who knows.

@dylanmckay
Copy link
Member Author

I'm going to change the default triple to avr-atmel-none. It is more conventional. Compiler-rt also requires a three-part triple.

@agnat
Copy link

agnat commented Jun 19, 2015

+1

@dylanmckay
Copy link
Member Author

I don't believe there is much (if any) effort required for this. avr-none is not hardcoded anywhere, it is simply the argument passed to configure.

The architecture avr is already supported. The vendor atmel is already supported. And I just added support for the none OS in bd61c32.

@dylanmckay
Copy link
Member Author

Closing as bd61c32 was all that needed to be done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants