Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression when alignment was set to 1 #82

Open
dylanmckay opened this issue Sep 27, 2017 · 0 comments
Open

Performance regression when alignment was set to 1 #82

dylanmckay opened this issue Sep 27, 2017 · 0 comments
Labels
A-llvm Affects the LLVM AVR backend enhancement

Comments

@dylanmckay
Copy link
Member

When #64 was fixed by changing all types to be byte aligned, a performance regression was introduced.

The upstream LLVM commit that caused this is r314179.

I discovered the regression when fixing the build in r314183.

If you look at r314183, you will see that we previously used a register when pushing 16-bit values onto the stack, whereas now we needlessly use an extra register.

@dylanmckay dylanmckay added A-llvm Affects the LLVM AVR backend enhancement labels Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-llvm Affects the LLVM AVR backend enhancement
Projects
None yet
Development

No branches or pull requests

1 participant