Skip to content

Commit 55f6a14

Browse files
Laurence Armstrongclareliguori
Laurence Armstrong
authored andcommitted
fix: change sanitization character from '*' to '_'
1 parent e8a9079 commit 55f6a14

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

index.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ const util = require('util');
88
const MAX_ACTION_RUNTIME = 6 * 3600;
99
const USER_AGENT = 'configure-aws-credentials-for-github-actions';
1010
const MAX_TAG_VALUE_LENGTH = 256;
11-
const SANITIZATION_CHARACTER = '*'
11+
const SANITIZATION_CHARACTER = '_'
1212

1313
async function assumeRole(params) {
1414
// Assume a role to get short-lived credentials using longer-lived credentials.

index.test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ const ENVIRONMENT_VARIABLE_OVERRIDES = {
2323
GITHUB_REF: 'MY-BRANCH',
2424
GITHUB_SHA: 'MY-COMMIT-ID',
2525
};
26-
const GITHUB_ACTOR_SANITIZED = 'MY-USERNAME*bot*'
26+
const GITHUB_ACTOR_SANITIZED = 'MY-USERNAME_bot_'
2727

2828
function mockGetInput(requestResponse) {
2929
return function (name, options) { // eslint-disable-line no-unused-vars
@@ -245,7 +245,7 @@ describe('Configure AWS Credentials', () => {
245245

246246
process.env = {...process.env, GITHUB_WORKFLOW: 'Workflow!"#$%&\'()*+, -./:;<=>?@[]^_`{|}~🙂💥🍌1yFvMOeD3ZHYsHrGjCceOboMYzBPo0CRNFdcsVRG6UgR3A912a8KfcBtEVvkAS7kRBq80umGff8mux5IN1y55HQWPNBNyaruuVr4islFXte4FDQZexGJRUSMyHQpxJ8OmZnET84oDmbvmIjgxI6IBrdihX9PHMapT4gQvRYnLqNiKb18rEMWDNoZRy51UPX5sWK2GKPipgKSO9kqLckZai9D2AN2RlWCxtMqChNtxuxjqeqhoQZo0oaq39sjcRZgAAAAAAA'};
247247

248-
const sanitizedWorkflowName = 'Workflow**********+, -./:;<=>?@***_********1yFvMOeD3ZHYsHrGjCceOboMYzBPo0CRNFdcsVRG6UgR3A912a8KfcBtEVvkAS7kRBq80umGff8mux5IN1y55HQWPNBNyaruuVr4islFXte4FDQZexGJRUSMyHQpxJ8OmZnET84oDmbvmIjgxI6IBrdihX9PHMapT4gQvRYnLqNiKb18rEMWDNoZRy51UPX5sWK2GKPipgKSO9kqLckZa'
248+
const sanitizedWorkflowName = 'Workflow__________+, -./:;<=>?@____________1yFvMOeD3ZHYsHrGjCceOboMYzBPo0CRNFdcsVRG6UgR3A912a8KfcBtEVvkAS7kRBq80umGff8mux5IN1y55HQWPNBNyaruuVr4islFXte4FDQZexGJRUSMyHQpxJ8OmZnET84oDmbvmIjgxI6IBrdihX9PHMapT4gQvRYnLqNiKb18rEMWDNoZRy51UPX5sWK2GKPipgKSO9kqLckZa'
249249

250250
await run();
251251
expect(mockStsAssumeRole).toHaveBeenCalledWith({

0 commit comments

Comments
 (0)