Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP_PROXY environment variable is ignored #1165

Closed
1 task
Titzi90 opened this issue Sep 26, 2024 · 4 comments
Closed
1 task

HTTP_PROXY environment variable is ignored #1165

Titzi90 opened this issue Sep 26, 2024 · 4 comments
Labels
bug Something isn't working needs-triage This issue still needs to be triaged

Comments

@Titzi90
Copy link

Titzi90 commented Sep 26, 2024

Describe the bug

According to your Documentation the action should concider the HTTP_PROXY environment variable:

Additionally this action will always consider the HTTP_PROXY environment variable.

However it seems it does not.

Running the following workflow behind a proxy does not work:

name: Proxy Test
on: workflow_dispatch
jobs:
  test:
    runs-on: self-hosted
    permissions:
      id-token: write   # This is required for requesting the JWT from awsG
      contents: read    # This is required for actions/checkout
    steps:
      - name: set proxy
        run: |
          echo "HTTP_PROXY=http://my-proxy.com" >> $GITHUB_ENV
          echo "HTTPS_PROXY=http://my-proxy.com" >> $GITHUB_ENV
      - name: Configure AWS credentials
        uses: aws-actions/configure-aws-credentials@v4
        with:
          role-to-assume: arn:aws:iam::1234567890
          aws-region: eu-west-1

while this action where the proxy is explicit set does work:

name: Proxy Test
on: workflow_dispatch
jobs:
  test:
    runs-on: self-hosted
    permissions:
      id-token: write   # This is required for requesting the JWT from awsG
      contents: read    # This is required for actions/checkout
    steps:
      - name: set proxy
        run: |
          echo "HTTP_PROXY=http://my-proxy.com" >> $GITHUB_ENV
          echo "HTTPS_PROXY=http://my-proxy.com" >> $GITHUB_ENV
      - name: Configure AWS credentials
        uses: aws-actions/configure-aws-credentials@v4
        with:
          role-to-assume: arn:aws:iam::1234567890
          aws-region: eu-west-1
          http-proxy: ${{ env.HTTP_PROXY }}

Regression Issue

  • Select this option if this issue appears to be a regression.

Expected Behavior

Example one to work as example two

Current Behavior

Example one fails to connect to aws (time out)

Reproduction Steps

see above

Possible Solution

No response

Additional Information/Context

No response

@Titzi90 Titzi90 added bug Something isn't working needs-triage This issue still needs to be triaged labels Sep 26, 2024
@Titzi90
Copy link
Author

Titzi90 commented Sep 27, 2024

I tested a few older versions of aws-actions/configure-aws-credentials.
It looks like it does work with v2 but stop working in v3:

name: Proxy Test
on: workflow_dispatch
jobs:
  test:
    runs-on: self-hosted
    permissions:
      id-token: write   # This is required for requesting the JWT from awsG
      contents: read    # This is required for actions/checkout
    steps:
      - name: set proxy
        run: |
          echo "HTTP_PROXY=http://my-proxy.com" >> $GITHUB_ENV
          echo "HTTPS_PROXY=http://my-proxy.com" >> $GITHUB_ENV
      - name: Configure AWS credentials
        uses: aws-actions/configure-aws-credentials@v2
        with:
          role-to-assume: arn:aws:iam::1234567890
          aws-region: eu-west-1

runs as expected and gives the following message:

Setting proxy from environment: http://my-proxy.com/

@Dboy554
Copy link

Dboy554 commented Oct 7, 2024

Nice

@kellertk
Copy link
Member

Please see #1061. Closing this as a duplicate issue.

@kellertk kellertk closed this as not planned Won't fix, can't repro, duplicate, stale Oct 15, 2024
Copy link

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage This issue still needs to be triaged
Projects
None yet
Development

No branches or pull requests

4 participants
@kellertk @Titzi90 @Dboy554 and others