Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eks-blueprint: Support for using digest in Helm provider #1120

Open
antmakedev opened this issue Mar 3, 2025 · 1 comment
Open

eks-blueprint: Support for using digest in Helm provider #1120

antmakedev opened this issue Mar 3, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@antmakedev
Copy link

Describe the bug

We are wanting to use helm digest's instead of just using a tag when using helm charts along with the EKS blueprints to raise the security bar. The CDK docs don't seem to mention using the digest at all and in the blueprints we seem to have limited the version (along with the name that has to be limited) to only 63 characters which doesn't support the length of the sha256 hash. The helm issue mentioned only seems to reference the name value being 63 characters due to DNS reasons not the version.

Expected Behavior

Expect to be able to reference the helm chart by its sha256 digest

image:
  registry: quay.io
  repository: myco/foo
  version: sha256:d478cd82cb6a604e3a27383daf93637326d402570b2f3bec835d1f84c9ed0acc

Current Behavior

Currently you are only able to specify it by value:

image:
  registry: quay.io
  repository: myco/foo
  version: 1.0.0

Reproduction Steps

https://github.com/shapirov103/eks-blueprints-extension/blob/main/lib/index.ts

Possible Solution

Increase the limit of the constraints on the value within HelmAddonPropsConstraints

version = new utils.StringConstraint(1, 63);

Additional Information/Context

No response

CDK CLI Version

NA

EKS Blueprints Version

No response

Node.js Version

NA

Environment details (OS name and version, etc.)

NA

Other information

No response

@antmakedev antmakedev added the bug Something isn't working label Mar 3, 2025
@shapirov103
Copy link
Collaborator

Can you confirm that deployment of this helm chart without CDK EKS Blueprints succeeds?
Also from the example it looks that that sha digest is the version, which seems to indicate that 256 chars is enough.
Since I was not able to find a constraint on the version I am planning to make it 1024, which seems to be reasonable to accommodate known use cases. I will also look into an approach to turn the validation off as the constraints while handy, may not be up to date with changes across various APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants