Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller should fail fast(er). #660

Open
eviln1 opened this issue Jul 30, 2024 · 1 comment
Open

Controller should fail fast(er). #660

eviln1 opened this issue Jul 30, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers small

Comments

@eviln1
Copy link

eviln1 commented Jul 30, 2024

Our team got hit by #658 today. The proposal in #659 would help a lot.

Additionally, I think that the controller should fail fast(er).

We use helm to install the controller, with the atomic: true option set; the rationale is that if the pods can't become ready, helm rolls back to the previous release.

Currently, the controller will become ready, but fail after a couple of minutes and go into CrashLoopBackOff.

Having the controller check for pre-requisites before becoming ready would prevent this behavior.

@zijun726911
Copy link
Contributor

Thank you for raising this issue. it make sense to make the controller fail faster in its initialization phase if some required resources does not installed in the cluster, and to make helm chart atomic: true behavior work as intended.

We will look into implementing this fast-fail logic, it's not quite hard to add it.

Thank you again for your input, and we appreciate your patience as we work on improving the controller.

@zijun726911 zijun726911 added enhancement New feature or request good first issue Good for newcomers small labels Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers small
Projects
None yet
Development

No branches or pull requests

2 participants