Skip to content

Commit ac8da7e

Browse files
authored
fix breakfix dataexchange updaterevision finalized (#3076)
* [breakfix] update Dataexchange#UpdateRevision$Finalized to be able to serialize a false value
1 parent cfef7b8 commit ac8da7e

File tree

4 files changed

+17
-4
lines changed

4 files changed

+17
-4
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"id": "2e75f566-e67f-4bd8-be9f-9a9421fed9d8",
3+
"type": "bugfix",
4+
"description": "**BREAKING CHANGE**: The type of Dataexchange#UpdateRevision$Finalized has been changed from `bool` to `*bool`. efore this change, the field was incorrectly marked as having a default value of false by the service, which made it functionally impossible for users to set this value to false",
5+
"modules": [
6+
"service/dataexchange"
7+
]
8+
}

codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/RemoveDefaults.java

+6-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,12 @@ public class RemoveDefaults implements GoIntegration {
3636
serviceToShapeIds("com.amazonaws.imagebuilder#imagebuilder",
3737
// https://github.com/aws/aws-sdk-go-v2/issues/2734
3838
// V1479153907
39-
"com.amazonaws.imagebuilder#LaunchTemplateConfiguration$setDefaultVersion"));
39+
"com.amazonaws.imagebuilder#LaunchTemplateConfiguration$setDefaultVersion"),
40+
serviceToShapeIds("com.amazonaws.dataexchange#DataExchange",
41+
// https://github.com/aws/aws-sdk-go-v2/issues/3066
42+
// we need to target synthetic shapes since we generate synthetic input shapes
43+
"smithy.go.synthetic#UpdateRevisionInput$Finalized")
44+
);
4045

4146
private boolean mustPreprocess(ShapeId service) {
4247
return toRemove.containsKey(service);

service/dataexchange/api_op_UpdateRevision.go

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

service/dataexchange/serializers.go

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)