bugfix: s3 path handling (#3038)

Author: stobrien89

src/Api/Serializer/RestSerializer.php

@@ -197,6 +197,7 @@ private function applyQuery($name, Shape $member, $value, array &$opts)
     private function buildEndpoint(Operation $operation, array $args, array $opts)
     {
         $isModifiedModel = $this->api->isModifiedModel();
+        $serviceName = $this->api->getServiceName();
         // Create an associative array of variable definitions used in expansions
         $varDefinitions = $this->getVarDefinitions($operation, $args);
 
@@ -225,7 +226,7 @@ function (array $matches) use ($varDefinitions) {
 
         $path = $this->endpoint->getPath();
 
-        if ($isModifiedModel && $this->api->getServiceName() === 's3') {
+        if ($isModifiedModel && $serviceName === 's3') {
             if (substr($path, -1) === '/' && $relative[0] === '/') {
                 $path = rtrim($path, '/');
             }
@@ -242,7 +243,9 @@ function (array $matches) use ($varDefinitions) {
             }
         }
 
-        if (!$isModifiedModel) {
+        if (!$isModifiedModel
+            && $serviceName !== 's3'
+        ) {
             $relative = $this->prependPath($relative, $path);
         }
 

src/Api/Service.php

@@ -219,7 +219,7 @@ public function getSigningName()
      */
     public function getServiceName()
     {
-        return $this->definition['metadata']['serviceIdentifier'];
+        return $this->definition['metadata']['serviceIdentifier'] ?? null;
     }
 
     /**