Skip to content

adf-accounts: Should it create new OUs if they don't exists? #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StewartW opened this issue May 20, 2020 · 1 comment
Open

adf-accounts: Should it create new OUs if they don't exists? #263

StewartW opened this issue May 20, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@StewartW
Copy link
Contributor

ADF Version: 3.0.1
`

  • account_full_name: "some-random-account"
    --
      | organizational_unit_path: /existing/new-ou
      | email: [email protected]
      | allow_billing: True
      | delete_default_vpc: False
      | alias: some-random-account
      | tags:
      | - managed_by_adf: True

`

In this kind of example, when adding a new account via adf-accounts/.yml

It will fail with a ValueError because it can't find the OU.
File Here

Do we think this should create the relevant OU if it doesn't exist?
What's the thoughts on that?
There's pros:

  • allows for smoother creation of OUs and moving accounts "as code"
  • keeps everything in the same process

Cons:

  • Could hide errors if there's a typo in an OU name
@thomasmcgannon thomasmcgannon added enhancement New feature or request good first issue Good for newcomers labels Sep 25, 2020
@ethanBaird
Copy link

Hey folks!

I've raised a PR to address this issue, here 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants