@@ -4,6 +4,7 @@ const path = require("path");
44const spawn = require ( "cross-spawn" ) ;
55const readPkg = require ( "read-pkg" ) ;
66const validatePkgName = require ( "validate-npm-package-name" ) ;
7+ const { extractJSONObject } = require ( "extract-first-json" ) ;
78/**
89 * @param {string } [filePathOrDirPath]
910 * @returns {Promise<readPkg.NormalizedPackageJson> }
@@ -63,43 +64,122 @@ const checkPrivateField = (packagePath) => {
6364 * or rejects if anything failed
6465 * @param packageName
6566 * @param registry
67+ * @param {{verbose : boolean} } options
6668 * @returns {Promise }
6769 */
68- const viewPackage = ( packageName , registry ) => {
70+ const viewPackage = ( packageName , registry , options ) => {
6971 return new Promise ( ( resolve , reject ) => {
7072 const registryArgs = registry ? [ "--registry" , registry ] : [ ] ;
7173 const view = spawn ( "npm" , [ "view" , packageName , "versions" , "--json" ] . concat ( registryArgs ) ) ;
72- let result = "" ;
73- let errorResult = "" ;
74+ let _stdoutResult = "" ;
75+ let _stderrResult = "" ;
7476
77+ /**
78+ * @param stdout
79+ * @param stderr
80+ * @returns {{stdoutJSON: null | {}, stderrJSON: null | {}} }
81+ */
82+ const getJsonOutputs = ( { stdout, stderr } ) => {
83+ let stdoutJSON = null ;
84+ let stderrJSON = null ;
85+ if ( stdout ) {
86+ try {
87+ stdoutJSON = JSON . parse ( stdout ) ;
88+ } catch ( error ) {
89+ // nope
90+ if ( options . verbose ) {
91+ console . error ( "stdoutJSON parse error" , stdout ) ;
92+ }
93+ }
94+ }
95+ if ( stderr ) {
96+ try {
97+ stderrJSON = JSON . parse ( stderr ) ;
98+ } catch ( error ) {
99+ // nope
100+ if ( options . verbose ) {
101+ console . error ( "stderrJSON parse error" , stdout ) ;
102+ }
103+ }
104+ }
105+ return {
106+ stdoutJSON,
107+ stderrJSON
108+ } ;
109+ } ;
110+ const isError = ( json ) => {
111+ return json && "error" in json ;
112+ } ;
113+ const is404Error = ( json ) => {
114+ return isError ( json ) && json . error . code === "E404" ;
115+ } ;
75116 view . stdout . on ( "data" , ( data ) => {
76- result += data . toString ( ) ;
117+ _stdoutResult += data . toString ( ) ;
77118 } ) ;
78119
79120 view . stderr . on ( "data" , ( err ) => {
80- errorResult += err . toString ( ) ;
121+ const stdErrorStr = err . toString ( ) ;
122+ // Workaround for npm 7
123+ // npm 7 --json option is broken
124+ // It aim to remove non json output.
125+ // FIXME: However,This logics will break json chunk(chunk may be invalid json)
126+ // https://github.com/azu/can-npm-publish/issues/19
127+ // https://github.com/npm/cli/issues/2740
128+ const jsonObject = extractJSONObject ( stdErrorStr ) ;
129+ if ( jsonObject ) {
130+ _stderrResult = JSON . stringify ( jsonObject , null , 4 ) ;
131+ }
81132 } ) ;
82133
83134 view . on ( "close" , ( code ) => {
135+ // Note:
136+ // npm 6 output JSON in stdout
137+ // npm 7(7.18.1) output JSON in stderr
138+ const { stdoutJSON, stderrJSON } = getJsonOutputs ( {
139+ stdout : _stdoutResult ,
140+ stderr : _stderrResult
141+ } ) ;
142+ if ( options . verbose ) {
143+ console . log ( "`npm view` command's exit code:" , code ) ;
144+ console . log ( "`npm view` stdoutJSON" , stdoutJSON ) ;
145+ console . log ( "`npm view` stderrJSON" , stderrJSON ) ;
146+ }
147+ // npm6 view --json output to stdout if the package is 404 → can publish
148+ if ( is404Error ( stdoutJSON ) ) {
149+ return resolve ( [ ] ) ;
150+ }
151+ // npm7 view --json output to stderr if the package is 404 → can publish
152+ if ( is404Error ( stderrJSON ) ) {
153+ return resolve ( [ ] ) ;
154+ }
155+ // in other error, can not publish → reject
156+ if ( isError ( stdoutJSON ) ) {
157+ return reject ( new Error ( _stdoutResult ) ) ;
158+ }
159+ if ( isError ( stderrJSON ) ) {
160+ return reject ( new Error ( _stderrResult ) ) ;
161+ }
162+ // if command is failed by other reasons(no json output), treat it as actual error
84163 if ( code !== 0 ) {
85- return reject ( new Error ( errorResult ) ) ;
164+ return reject ( new Error ( _stderrResult ) ) ;
86165 }
87- const resultJSON = JSON . parse ( result ) ;
88- if ( resultJSON && resultJSON . error ) {
89- // the package is not in the npm registry => can publish
90- if ( resultJSON . error . code === "E404" ) {
91- return resolve ( [ ] ) ; // resolve as empty version
92- } else {
93- // other error => can not publish
94- return reject ( new Error ( errorResult ) ) ;
95- }
166+ if ( stdoutJSON ) {
167+ // if success to get, resolve with versions json
168+ return resolve ( stdoutJSON ) ;
169+ } else {
170+ return reject ( _stderrResult ) ;
96171 }
97- resolve ( resultJSON ) ;
98172 } ) ;
99173 } ) ;
100174} ;
101175
102- const checkAlreadyPublish = ( packagePath ) => {
176+ /**
177+ *
178+ * @param {string } packagePath
179+ * @param {{verbose : boolean} } options
180+ * @returns {Promise<readPkg.NormalizedPackageJson> }
181+ */
182+ const checkAlreadyPublish = ( packagePath , options ) => {
103183 return readPkgWithPath ( packagePath ) . then ( ( pkg ) => {
104184 const name = pkg [ "name" ] ;
105185 const version = pkg [ "version" ] ;
@@ -111,7 +191,7 @@ const checkAlreadyPublish = (packagePath) => {
111191 if ( version === undefined ) {
112192 return Promise . reject ( new Error ( "This package has no `version`." ) ) ;
113193 }
114- return viewPackage ( name , registry ) . then ( ( versions ) => {
194+ return viewPackage ( name , registry , options ) . then ( ( versions ) => {
115195 if ( versions . includes ( version ) ) {
116196 return Promise . reject ( new Error ( `${ name } ${ version } ) ) ;
117197 }
@@ -128,7 +208,7 @@ const checkAlreadyPublish = (packagePath) => {
128208const canNpmPublish = ( packagePath , options = { verbose : false } ) => {
129209 return Promise . all ( [
130210 checkPkgName ( packagePath , options ) ,
131- checkAlreadyPublish ( packagePath ) ,
211+ checkAlreadyPublish ( packagePath , options ) ,
132212 checkPrivateField ( packagePath )
133213 ] ) ;
134214} ;
0 commit comments