Fix NewDateRegex in StringExtensions restsharp#1556

b-c-ds · b-c-ds · commit c035d7384c46 · 2021-02-16T20:02:28.000Z
Previously it had exponential worst-case complexity and was vulnerable to REDoS.
diff --git a/src/RestSharp/Extensions/StringExtensions.cs b/src/RestSharp/Extensions/StringExtensions.cs
@@ -25,7 +25,7 @@ namespace RestSharp.Extensions
     public static class StringExtensions
     {
         static readonly Regex DateRegex    = new Regex(@"\\?/Date\((-?\d+)(-|\+)?([0-9]{4})?\)\\?/");
-        static readonly Regex NewDateRegex = new Regex(@"newDate\((-?\d+)*\)");
+        static readonly Regex NewDateRegex = new Regex(@"newDate\((-?\d+)\)");
 
         static readonly Regex IsUpperCaseRegex = new Regex(@"^[A-Z]+$");
 

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ namespace RestSharp.Extensions`
`25`	`25`	`public static class StringExtensions`
`26`	`26`	`{`
`27`	`27`	`static readonly Regex DateRegex = new Regex(@"\\?/Date\((-?\d+)(-\|\+)?([0-9]{4})?\)\\?/");`
`28`		`- static readonly Regex NewDateRegex = new Regex(@"newDate\((-?\d+)*\)");`
	`28`	`+ static readonly Regex NewDateRegex = new Regex(@"newDate\((-?\d+)\)");`
`29`	`29`
`30`	`30`	`static readonly Regex IsUpperCaseRegex = new Regex(@"^[A-Z]+$");`
`31`	`31`