🐛 Reset stored error when handler is re-inited or setup is re-run. (ossf#2893)

* Reset stored error when checkruns handler is re-inited or setup is run agaain.

Signed-off-by: Spencer Schrock <[email protected]>

* Add test.

Signed-off-by: Spencer Schrock <[email protected]>

---------

Signed-off-by: Spencer Schrock <[email protected]>
Signed-off-by: Avishay <[email protected]>

Author: spencerschrock

clients/githubrepo/checkruns.go

@@ -89,10 +89,12 @@ func (handler *checkrunsHandler) init(ctx context.Context, repourl *repoURL, com
 	handler.checkData = new(checkRunsGraphqlData)
 	handler.setupOnce = new(sync.Once)
 	handler.checkRunsByRef = checkRunsByRef{}
+	handler.errSetup = nil
 }
 
 func (handler *checkrunsHandler) setup() error {
 	handler.setupOnce.Do(func() {
+		handler.errSetup = nil
 		commitExpression := handler.repourl.commitExpression()
 		vars := map[string]interface{}{
 			"owner":                 githubv4.String(handler.repourl.owner),

clients/githubrepo/checkruns_test.go

@@ -0,0 +1,30 @@
+// Copyright 2023 OpenSSF Scorecard Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package githubrepo
+
+import (
+	"context"
+	"testing"
+
+	sce "github.com/ossf/scorecard/v4/errors"
+)
+
+func Test_init_clearsErr(t *testing.T) {
+	handler := &checkrunsHandler{errSetup: sce.ErrScorecardInternal}
+	handler.init(context.Background(), nil, 0)
+	if handler.errSetup != nil {
+		t.Errorf("expected nil error, got %v", handler.errSetup)
+	}
+}